New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Files app: Audio player in quick view is clipped.

Project Member Reported by fukino@chromium.org, Mar 28 2018

Issue description

What steps will reproduce the problem?
(1) Open Files app
(2) Select an audio file and press SPACE key to show quick view.

What is the expected result?
The mini audio player should be shown normally.

What happens instead?
The mini audio player is clipped as seen in the attached screenshot.

This seems a regression of M-67. The default UI for <audio> elements gets bigger height value recently.
 
Screenshot from 2018-03-29 04-26-21.png
63.3 KB View Download

Comment 1 by fukino@chromium.org, Mar 28 2018

WIP CL: https://crrev.com/c/984914
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85415b61a0d6e68a2109bad8f0d4013031410ae2

commit 85415b61a0d6e68a2109bad8f0d4013031410ae2
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Apr 04 09:48:08 2018

Files app: Expand region of audio control in quick view.

The default audio controls for <audio> tag gets bigger recently.
To fit the control, the region for audio control in quick view needs to be
bigger.
This is a quick fix to fix the regression.
The quick view should handle any size of audio control. It should be fixed by a
separated CL.

Bug:  826860 
Test: Manually tested by mp3 files with and without cover arts.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib6cae6bc514d05090b65e076fcc276c8a3aabbca
Reviewed-on: https://chromium-review.googlesource.com/984914
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548014}
[modify] https://crrev.com/85415b61a0d6e68a2109bad8f0d4013031410ae2/ui/file_manager/file_manager/foreground/elements/files_safe_media.html

Status: Fixed (was: Assigned)

Sign in to add a comment