New issue
Advanced search Search tips

Issue 826838 link

Starred by 3 users
Status: Fixed
Owner:
lgrey@chromium.org
Closed: Mar 2018
Cc:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViewsBrowser: Cmd+Enter in the Omnibox does not open existing URL in new tab

Project Member Reported by rsesek@chromium.org, Mar 28 2018 
Chrome Version: 67.0.3382.0
OS: macOS 10.13.3

What steps will reproduce the problem?
(1) --enable-features=ViewsBrowserWindows
(2) Go to www.google.com in a new tab
(3) Focus the Omnibox
(4) Press Cmd+Enter

What is the expected result?
A new tab opens to www.google.com. The Cmd modifier should cause the address to be opened in a new tab.

What happens instead?
The existing tab navigates.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by lgrey@chromium.org, Mar 28 2018

Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Gonna self-assign this since this may be related to another issue I'm working on.

Comment 2 by ellyjo...@chromium.org, Mar 29 2018

Labels: Target-67 M-67

Comment 3 by gov...@chromium.org, Mar 29 2018 

** Bulk Edit **

There are only two M67 dev releases left on 04/03 & 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0055a7a5681fd439064a757f2cf59152f3e8e0e7

commit 0055a7a5681fd439064a757f2cf59152f3e8e0e7
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Mar 30 00:14:46 2018

MacViews: Allow Command key as modifier to open a new tab in the background from the Omnibox

This matches Cocoa behavior.

Bug:  826838 
Change-Id: I85e1325ecf1c025fe05c5967d00845cd2f56dea2
Reviewed-on: https://chromium-review.googlesource.com/986852
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547037}
[modify] https://crrev.com/0055a7a5681fd439064a757f2cf59152f3e8e0e7/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Comment 5 by gov...@chromium.org, Mar 30 2018

Cc: ellyjo...@chromium.org
Can this be marked as fixed on anything is pending here?

Comment 6 by lgrey@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)
Fixed, but it didn't make the Canary cut, so not marking verified yet

Comment 7 by viswa.karala@chromium.org, Apr 2 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3386.0
Able to reproduce the issue on chrome reported version Canary 67.0.3382.0
Verified the fix on Mac 10.12.6 on Chrome version #67.0.3386.0 as per the comment#0
Attaching screen cast for reference.
Observed "On pressing Cmd+Enter, searched URL opens in New tab"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
826838.mp4
657 KB View Download
►

Sign in to add a comment