Tricium plugin: upgrade from gapi.auth to gapi.auth2? |
||||
Issue descriptionThe buildbucket and tricium Gerrit plugins use gapi.auth to get an OAuth2 bearer token which they use to authenticate with the buildbucket/tricium services on behalf of the logged-in user. gapi.auth is now deprecated (more than a year ago...) and the replacement is called gapi.auth2. https://github.com/google/google-api-javascript-client/issues/280#issuecomment-280479373 I suspect that this is why the tricium plugin on the gerrit-review gerrit host is not getting any oauth2 token, and that this is why the Tricium plugin is broken there. Note: gapi.auth apparently continues to work on chromium-review and other gerrit hosts for now. Related documentation: https://developers.google.com/api-client-library/javascript/features/authentication
,
Apr 2 2018
,
Apr 2 2018
I'm not sure if this is what needs to be done; in https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/391034 I see that at the time when the gapi.auth code was added, masayasuzuki@ deliberately used gapi.auth instead of gapi.auth2 to avoid popups.
,
Apr 13 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Mar 28 2018