New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826828 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

77.9%-82.6% regression in system_health.common_desktop at 545919:546063

Project Member Reported by npm@chromium.org, Mar 28 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 28 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=826828

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=db5a666e3a21ba84ba697ed6c695ac5c10ea8390f91fcd31b14376fdb399b3d5


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 29 2018

Cc: thestig@chromium.org benchan@chromium.org
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12855587440000

Use unique_ptrs in MessagePumpLibevent::FileDescriptorWatcher. by thestig@chromium.org
https://chromium.googlesource.com/chromium/src/+/21476d052ea2fce4cc0e06826afd25ce0bff942b

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -benchan@chromium.org -thestig@chromium.org
Labels: OS-Windows
Owner: ----
Status: Untriaged (was: Assigned)
base/message_loop/message_pump_libevent.cc is not built on Windows. Changes to it can't possibly affect performance on Windows.
Cc: tdres...@chromium.org
Status: WontFix (was: Untriaged)
WontFix-ing because this recovered, but cc-ing tdresser since the eqt metric is pretty noisy here; pinpoint reproduced a regression at a CL that isn't built into Windows. (Note we re-use binaries, so compile differences between binaries are consistent for pinpoint)
Some of the EQT graphs look pretty non-noisy and non-recovered.

It's weird how stable the graph can look, and we can still have pinpoint unable to repro.

Comment 8 by npm@chromium.org, Apr 5 2018

Status: Untriaged (was: WontFix)
Yea I feel like bisects have been behaving very differently to graphs recently... not sure if it's a problem with the machines or the metrics though. Let's retry a bisect.
Cc: eyaich@chromium.org csharrison@chromium.org
Owner: csharrison@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/159818d0c40000

Add components_perftests to chromium.perf.json by csharrison@chromium.org
https://chromium.googlesource.com/chromium/src/+/a33ba78b7502b9bfad38cfd48fa5f8ff698bac79

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: ----
Status: Untriaged (was: Assigned)
Is it common for adding some perf tests to cause regressions in other benchmarks? That seems strange, so I'm not quite sure if the bisect is correct.

Moving myself to cc

Comment 12 by npm@chromium.org, Apr 6 2018

Ok last try...
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12b4d158c40000
For some reason this was only bisected on EQT but there are first paint regressions too. Trying to bisect some of those.
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Apr 12 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12eb4592c40000
Project Member

Comment 19 by 42576172...@developer.gserviceaccount.com, Apr 13 2018

Cc: dproy@chromium.org benjhayden@chromium.org
Owner: dproy@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/120cbefcc40000

Get navigation info without using FrameLoader snapshots by dproy@chromium.org
https://chromium.googlesource.com/catapult/+/5d35a2c7122c1ac4a9a37e7743a19f628f25a38b

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 20 by dproy@chromium.org, Apr 13 2018

This is weird. Before my change, FMP was being calculated for "https://myaccount.google.com/?pli=1" - that feels wrong. After the change, FMP is now being calculated for "https://mail.google.com/mail/", which feels more correct. Maybe some benchmark owner has more context here? 

 Issue 831089  might be relevant. 
Project Member

Comment 21 by 42576172...@developer.gserviceaccount.com, Apr 13 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12f5ad02c40000

Comment 22 by dproy@chromium.org, Apr 23 2018

Cc: nednguyen@chromium.org kouhei@chromium.org
This root cause of this issue is similar to  Issue 827145 . Adding Ned and Kouhei. 
Components: Speed>Metrics>SystemHealthRegressions
friendly ping from today's perf sheriff
Ping! This bug has been flagged as stale by Chrome Speed Metrics bug triage, and it has an owner. Any update on this issue?
Status: WontFix (was: Assigned)
Based on c#20, I'm going to say the metric was wrong before and is correct now. Marking as WontFix.

Sign in to add a comment