New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826826 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 827995
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.8% regression in system_health.common_mobile at 545707:545707

Project Member Reported by npm@chromium.org, Mar 28 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 28 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=826826

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fdb9203e490a4bd59fef0685e8a6f1bc52ee1ecd7eccce2cd8f1226b04e96e65


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 28 2018

Status: Assigned (was: Untriaged)
Assigning to chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com because this is the only CL in range:
Roll src/third_party/chromite/ e6139afa1..44123785c (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/e6139afa10f8..44123785ca9a

$ git log e6139afa1..44123785c --date=short --no-merges --format='%ad %ae %s'
2018-03-24 ihf chromeos-config: mark eve-arcnext-chrome-pfq important.
2018-03-23 achuith cros_vm: Determine SDK version outside SDK shell.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:825539, chromium:823996 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Icb8dcad2d3ee70b331e2446f9f873e2c21c385d8
Reviewed-on: https://chromium-review.googlesource.com/979598
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545707}
Status: Untriaged (was: Assigned)
This graph is pretty noisy, bisecting on a wider range.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14e6bde8c40000
Cc: ishell@chromium.org ahaas@chromium.org v8-autoroll@chromium.org verwa...@chromium.org ivo.mark...@mips.com
Owner: ishell@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/149d30d3c40000

Force proper code aligment in wasm serializer. by ivo.markovic@mips.com
https://chromium.googlesource.com/v8/v8/+/5dca2bd7ee5e854090e37633684a81eceb60f9ee

Update V8 to version 6.7.159.1 (cherry-pick). by v8-autoroll@chromium.org
https://chromium.googlesource.com/chromium/src/+/6dda25c3a237e3ea2dec20a830c58973918ea9fd

[ic] Use Map as transition handlers instead of StoreHandler objects. by ishell@chromium.org
https://chromium.googlesource.com/v8/v8/+/78c6bbd930b9138002cfb52642b90b9aab104a78

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Looking at the bisect results the culprit is indeed more likely:

[ic] Use Map as transition handlers instead of StoreHandler objects. by ishell@chromium.org
https://chromium.googlesource.com/v8/v8/+/78c6bbd930b9138002cfb52642b90b9aab104a78

ishell, can you investigate?
Components: Speed>Metrics>SystemHealthRegressions
Owner: verwa...@chromium.org
perf sheriff triage:

since ishell@'s last login was > 30 days ago, let me assign verwaest@ who reviewed the suspected CL instead.
Mergedinto: 827995
Status: Duplicate (was: Assigned)

Sign in to add a comment