NotificationPlatformBridgeWin ignores incognito? |
||
Issue descriptionIt seems that the incognito bit is important to help identify the profile, yet it doesn't appear to be used. This would mean that notifications generated by an incognito profile and its original profile would overlap/overwrite each other. It's also seemingly problematic that NotificationPlatformBridge::Close doesn't even have an incognito field, although that would be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/982648 See discussion at https://chromium-review.googlesource.com/c/chromium/src/+/982648/4/chrome/browser/notifications/notification_platform_bridge.h#b50
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c8854dd178f1a475200c52c254825117a76d010 commit 2c8854dd178f1a475200c52c254825117a76d010 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Tue Apr 24 14:59:04 2018 Win Native Notifications: Add profile id and incognito status to hashed tag. Also fix a parameter mismatch in the Close function. Bug: 834101 , 826817 , 734095 Change-Id: I94bef0defae6c7179605db23bfc8ff0020433f75 Reviewed-on: https://chromium-review.googlesource.com/1023231 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#553105} [modify] https://crrev.com/2c8854dd178f1a475200c52c254825117a76d010/chrome/browser/notifications/notification_platform_bridge_win.cc [modify] https://crrev.com/2c8854dd178f1a475200c52c254825117a76d010/chrome/browser/notifications/notification_platform_bridge_win.h [modify] https://crrev.com/2c8854dd178f1a475200c52c254825117a76d010/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc
,
Apr 24 2018
No longer ignoring incognito. Thanks for the heads up, Evan! |
||
►
Sign in to add a comment |
||
Comment 1 by rhalavati@chromium.org
, Apr 16 2018