WebView Tracing API: Replace exceptions with errors on start |
||||||
Issue descriptionneeded for exceptions to be consistently thrown on the calling thread
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c92c8615de02790112e074dc60846d569410ca0 commit 0c92c8615de02790112e074dc60846d569410ca0 Author: Tim Volodine <timvolodine@chromium.org> Date: Wed Mar 28 19:26:16 2018 [Android WebView] Tracing API: replace exceptions with errors on start. Update api to return errors on start so that they can be processed in the caller (glue layer) and appropriate exceptions can be thrown. This is needed to make sure the exceptions are thrown on the original calling thread (without resorting to other multithreaded techinques such as locking) BUG=781249, 826816 Change-Id: I93611e046180b964d1abb6b71eeb2811885c3a1e Reviewed-on: https://chromium-review.googlesource.com/981133 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546562} [modify] https://crrev.com/0c92c8615de02790112e074dc60846d569410ca0/android_webview/java/src/org/chromium/android_webview/AwTracingController.java
,
Mar 28 2018
requesting merge to M66 (needed for proper exception handling & to pass CTS)
,
Mar 28 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e066ec3a0c04560ca675d3e4d40b875455fc130a commit e066ec3a0c04560ca675d3e4d40b875455fc130a Author: Tim Volodine <timvolodine@chromium.org> Date: Thu Mar 29 15:54:46 2018 [Android WebView] Tracing API: replace exceptions with errors on start. MERGE to M66. Update api to return errors on start so that they can be processed in the caller (glue layer) and appropriate exceptions can be thrown. This is needed to make sure the exceptions are thrown on the original calling thread (without resorting to other multithreaded techinques such as locking) BUG=781249, 826816 Change-Id: I93611e046180b964d1abb6b71eeb2811885c3a1e Reviewed-on: https://chromium-review.googlesource.com/981133 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#546562}(cherry picked from commit 0c92c8615de02790112e074dc60846d569410ca0) Reviewed-on: https://chromium-review.googlesource.com/986235 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#495} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/e066ec3a0c04560ca675d3e4d40b875455fc130a/android_webview/java/src/org/chromium/android_webview/AwTracingController.java
,
Apr 20 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by timvolod...@chromium.org
, Mar 28 2018