New issue
Advanced search Search tips

Issue 826810 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 10
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Revert button appears for a moment when opening a CL

Project Member Reported by hnakashima@chromium.org, Mar 28 2018 
I don't have Committer status, so I suppose I can't revert CLs anymore. 

The Revert button still appears for a moment, enough for me to be able to click it and open the revert popup. It should appear only if the user can revert the CL.

Comment 1 by aga...@chromium.org, Mar 28 2018

Cc: vikt...@google.com
Unfortunately I don't think there's any way around this. The plugin which removes the Revert button from view for non-committers is dynamically loaded by the frontend, and isn't guaranteed to load faster than the buttons themselves.

Viktar, any chance you have ideas on how to improve this?

Comment 2 by vikt...@google.com, Apr 11 2018

Status: (was: Untriaged)
Should be fixed with https://gerrit-review.googlesource.com/c/gerrit/+/170530

Comment 3 by benhenry@google.com, Jan 10 

This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.

Comment 4 by benhenry@google.com, Jan 10

Status: Untriaged

Comment 5 by ajp@chromium.org, Jan 10

Cc: -vikt...@google.com
Status: Fixed (was: Untriaged)
Assuming this was fixed with the merge of https://gerrit-review.googlesource.com/c/gerrit/+/170530.
►

Sign in to add a comment