Touchable chrome / md refresh: Guest mode omnibox overflows border |
||
Issue descriptionChrome Version: Trunk: 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7 When there's no bookmark star or any other location-bar icons the omnibar will overflow its borders. Repro: Avatar switcher -> guest mode. New tab page has no star icons in this mode so the omnibar overflows. I suspect this is related to crrev.com/c/915483 so we might just need a bit of padding when there's no icons. Feel free to reassign if you're swamped. :)
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74c90317c654f6f91b5a780c671748ea902b7259 commit 74c90317c654f6f91b5a780c671748ea902b7259 Author: Patti <patricialor@chromium.org> Date: Tue Apr 10 02:34:38 2018 Omnibox/Views: Prevent the textfield overflowing into the rounded corners. In touch mode, the LocationBarView is a pill-shape. The textfield inside it - OmniboxViewViews - is not. This can cause the sharp corners of OmniboxViewViews to overflow or poke out of the rounded corners of LocationBarView when there are no leading or trailing decorations to act as padding, which can happen in Guest mode (no bookmark star). Prevent this from happening by adding padding to the left and right of OmniboxViewViews when there are no decorations. Bug: 826798 , 801583 Change-Id: Ibf75218b8c76809fca2811eb87bdaea243a71955 Reviewed-on: https://chromium-review.googlesource.com/994832 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#549388} [modify] https://crrev.com/74c90317c654f6f91b5a780c671748ea902b7259/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc [modify] https://crrev.com/74c90317c654f6f91b5a780c671748ea902b7259/chrome/browser/ui/views/location_bar/background_with_1_px_border.h [modify] https://crrev.com/74c90317c654f6f91b5a780c671748ea902b7259/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/74c90317c654f6f91b5a780c671748ea902b7259/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/74c90317c654f6f91b5a780c671748ea902b7259/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc
,
Apr 10 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by patricia...@chromium.org
, Apr 4 2018