Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fdoray@chromium.org ...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Builders failed on: - WebKit Linux Trusty: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty
Failure from https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12/12867: 09:47:06.503 20754 worker/2 bluetooth/requestDevice/chooser/new-scan-device-added.html crashed, (stderr lines): 09:47:06.503 20754 [21119:775:0328/094706.479597:ERROR:validation_errors.cc(87)] Invalid message: VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD 09:47:06.504 20754 [21119:775:0328/094706.479699:ERROR:render_process_host_impl.cc(4266)] Terminating render process for bad Mojo message: Received bad user message: Validation failed for FakeBluetoothChooser RequestValidator [VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD] 09:47:06.504 20754 [21119:775:0328/094706.479721:ERROR:bad_message.cc(25)] Terminating renderer for bad IPC message, reason 123 09:47:06.506 20719 [1860/10361] bluetooth/requestDevice/chooser/new-scan-device-added.html failed unexpectedly (renderer crashed) 09:47:06.505 20754 worker/2 killing primary driver 09:47:06.505 20754 worker/2 killing secondary driver 09:47:06.505 20754 worker/2 bluetooth/requestDevice/chooser/new-scan-device-added.html failed: 09:47:06.505 20754 worker/2 renderer crashed
Revert created at https://chromium-review.googlesource.com/c/chromium/src/+/984299
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42624492cd5e80855f1dd3a5a8146b258def2c2a commit 42624492cd5e80855f1dd3a5a8146b258def2c2a Author: François Doray <fdoray@chromium.org> Date: Wed Mar 28 19:48:22 2018 Revert "bluetooth: FakeBluetoothChooser impl." This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7. Reason for revert: https://crbug.com/826787 Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > BUG=719827,719826, 824704 > > Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3 > Reviewed-on: https://chromium-review.googlesource.com/962983 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Conley Owens <cco3@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546509} TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719827, 719826, 824704 , 826787 Reviewed-on: https://chromium-review.googlesource.com/984299 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#546572} [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/test/fake_peripheral.cc [add] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [add] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a337f19713e049cd42969b0c909c59aff4146cd commit 6a337f19713e049cd42969b0c909c59aff4146cd Author: Ovidio Henriquez <odejesush@chromium.org> Date: Thu Mar 29 05:16:26 2018 bluetooth: FakeBluetoothChooser impl. Implements the interfaces that FakeBluetoothChooser overrides. The mojom::FakeBluetoothChooser overrides are implemented by running |event_handler_| with the appropriate arguments. The BluetoothChooser overrides do nothing at the moment, since the base class is only meant to update the chooser user interface. This change also begins to partially convert a Bluetooth chooser test to test the interface and deletes the temporary tests that were created to test this API. This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which reverted the original change. The original change caused the new-scan-device-added.html test to fail because of a Mojo validation error resulting from not updating the third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js file needed by the test. Bug: 719827, 719826, 824704 , 826787 Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 Reviewed-on: https://chromium-review.googlesource.com/985195 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#546729} [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/test/fake_peripheral.cc [delete] https://crrev.com/fad0f0ae8508c3df9a7eed21de48065117c7a753/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [delete] https://crrev.com/fad0f0ae8508c3df9a7eed21de48065117c7a753/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d04a1e5256a9fdd78f40cbdb73355408614e14f3 commit d04a1e5256a9fdd78f40cbdb73355408614e14f3 Author: François Doray <fdoray@chromium.org> Date: Thu Mar 29 16:27:57 2018 Revert "bluetooth: FakeBluetoothChooser impl." This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd. Reason for revert: https://crbug.com/824704 These tests are failing: external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which > reverted the original change. The original change caused the > new-scan-device-added.html test to fail because of a Mojo validation error > resulting from not updating the > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js > file needed by the test. > > Bug: 719827, 719826, 824704 , 826787 > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 > Reviewed-on: https://chromium-review.googlesource.com/985195 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546729} TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719827, 719826, 824704 , 826787 Reviewed-on: https://chromium-review.googlesource.com/986592 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#546851} [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/test/fake_peripheral.cc [add] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [add] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
Removing sheriff label since tests are green now. Please be careful when relanding, thanks.
Comment 1 by fdoray@chromium.org
, Mar 28 2018