I'm confused by the title: "profile" to me means the thing specified with "./setup_board $BOARD --profile=testbed-ap". Is this issue intended to track moving those as well?

I'd like to see both the profile and corresponding features/testbed-ap overlay moved to public overlays (where possible) as well.  I can open a new issue if you'd prefer that.


BTW, to whoever moves these, please rename both to "wifi-testbed" since these are not functioning APs by default - just regular computers with an extra WIFI radio (e.g. stumpy or panther).

Here are the directories I'd like to see moved:
~/trunk/src $ find private-overlays/ -name \*testbed-ap\*
private-overlays/chromeos-overlay/profiles/features/testbed-ap
private-overlays/chromeos-overlay/chromeos-base/wifi-testbed-ap
...
private-overlays/overlay-whirlwind-private/profiles/testbed-ap
private-overlays/overlay-panther-private/profiles/testbed-ap

I've already posted one CL to move stumpy testbed profile but would like to rename the profile to be wifi-testbed:
   https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/927228

(This is really only intended as a example since stumpy testbed-ap won't currently pass wifi_matfunc running R65 build and I haven't debugged why not.)


BTW2, one more reason to rename the profile: Don Garrett wants to remove all uses of "shared builders" like testbed-ap builder (multiple profiles use one builder - which is not the same as a uni-build like coral which one profile supports multiple $BOARDs).

Renaming would allow Don to setup a new builder for each wifi-testbed $BOARD we want to support going forward: whirlwind for sure, gale likely. I can help plan deprecating stumpy and panther builds and when those testbed-ap profiles can be removed in the future (public or private).

I was targeting the core components. i.e., something like this:

private-overlays/chromeos-overlay/profiles/features/testbed-ap
private-overlays/chromeos-overlay/chromeos-base/wifi-testbed-ap

which should move to chromiumos-overlay.

The overlay-specific profiles that make use of these are a related benefit, and could be covered here or in  issue 809792 . I don't particularly care. The ones that currently can be built publicly are dying (stumpy and panther), and the ones we are maintaining (whirlwind and prospectively gale) don't have a public overlay.

> BTW2, one more reason to rename the profile: Don Garrett wants to remove all uses of "shared builders" like testbed-ap builder

I'm not sure how that's relevant. AIUI, the profile name is independent of the builder name -- although keeping them correlated is probably a nice feature.

I'm realizing there's very little in the wifi-testbed repository that we actually want to keep -- only a few init scripts and some tiny frame-management utilities. The rest is stuff we should just kill.

Is there any reason not to just move those few bits to platform2/, instead of moving to a new platform/ (public) repo? See the result of this:

https://chrome-internal-review.googlesource.com/#/c/chromeos/platform/wifi-testbed/+/607137

Yup - I think you are right. I was just looking through it again. The regulatory bits might need more review before publishing.

I think your CL should land anyway.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/wifi-testbed/+/c2f882cca01849cdde111cd8a43e080938772d5d

commit c2f882cca01849cdde111cd8a43e080938772d5d
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Apr 12 11:25:22 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/54b7b5ca8fd8603d6480d39512c1e80ad24f126d

commit 54b7b5ca8fd8603d6480d39512c1e80ad24f126d
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Apr 12 11:25:19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e2ae1034a6651a055f5f41e3cadbc76523698125

commit e2ae1034a6651a055f5f41e3cadbc76523698125
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Apr 12 11:25:18 2018

wifi-testbed: port tools from platform/wifi-testbed

This is one step towards building a wifi-testbed image from public
sources. We would like partners to be able to build/debug/fix issues
related to wifi testing.

These sources were already BSD licensed, so subsume the LICENSE into the
top-level license.

Tiny modifications from platform/wifi-testbed/:
 * renamed wifi-testbed-init/ to init/
 * modified README -> README.md with small changes
 * added OWNERS

BUG=chromium:826776
TEST=build chromeos-base/wifi-testbed-ap before/after; no change

Change-Id: Ib7795535f40de6d64b668823b97e014d6905f7ea
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1008971
Reviewed-by: Grant Grundler <grundler@chromium.org>

[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/OWNERS
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/init/shill.override
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/testbed-regulatory/ieee80211_header.h
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/init/87-testbed_regulatory.rules
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/init/wifi-testbed-init.conf
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/testbed-regulatory/send_management_frame.c
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/testbed-regulatory/testbed_regulatory.c
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/README.md
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/init/10-network-device-names.rules
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/testbed-regulatory/Makefile
[modify] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/README.md
[add] https://crrev.com/e2ae1034a6651a055f5f41e3cadbc76523698125/wifi-testbed/.gitignore

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/c696f221882bf0ebda57b98bb825c5c1667f3cce

commit c696f221882bf0ebda57b98bb825c5c1667f3cce
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Apr 12 22:22:19 2018

thanks for all this cleanup work!  it's great to see it go public.