[MacViews-Browser] Omnibox and the Dropdown are not dark in Incognito Mode |
||||||
Issue descriptionChrome Version: Canary 67.0.3382.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable chrome://flags/#views-browser-windows (2) Open an Incognito Window (3) Type something into the Omnibox, so that the Dropdown appears What is the expected result? A dark Omnibox Dropdown. What happens instead? The Dropdown has the default (white) color.
,
Mar 29 2018
Same for the Omnibox itselves. It is also not dark in Incognito. Please let me know, if I should file a separate report for it. Thanks.
,
Mar 29 2018
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Apr 17 2018
,
Apr 17 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0802868fe473bbcf439a05e029b9e30f597a085 commit c0802868fe473bbcf439a05e029b9e30f597a085 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 18 16:05:52 2018 ui: expose NativeThemeAura and NativeThemeAuraDark on all platforms These themes are Aura themes, but do not depend on USE_AURA or any Aura code, so it is fine to expose them on other platforms. This allows the Mac "legacy" omnibox to use the same logic around NativeThemeAuraDark as other platforms do. Bug: 826754 Change-Id: I69a6ffd5ebbb52cd2765edc99ec4b8c567e71e41 Reviewed-on: https://chromium-review.googlesource.com/1014738 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#551702} [modify] https://crrev.com/c0802868fe473bbcf439a05e029b9e30f597a085/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/c0802868fe473bbcf439a05e029b9e30f597a085/ui/native_theme/BUILD.gn [modify] https://crrev.com/c0802868fe473bbcf439a05e029b9e30f597a085/ui/native_theme/native_theme_aura.cc
,
Apr 18 2018
,
Apr 19 2018
Able to reproduce this issue on reported version 67.0.3382.0 hence verifying the fix on latest canary 68.0.3400.0 Observing black Omnibox and suggestion list. Attaching screenshot for reference. As fix is working as expected adding Verified labels. Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lgrey@chromium.org
, Mar 28 2018Status: Available (was: Untriaged)