New issue
Advanced search Search tips

Issue 826753 link

Starred by 1 user
Status: Fixed
Owner:
npm@chromium.org
Closed: Apr 2018
Cc:
tdres...@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

EQT for site isolation: mitigate trivial improvement

Project Member Reported by npm@chromium.org, Mar 28 2018 
With site isolation, EQT will improve, but not necessarily in a way that visibly improves user website. For example, consider a sample website that has a tiny iframe that does a very limited amount of work. If the EQT without site isolation is x, then the average EQT for the two renderers under site isolation will be x/2 because the renderer for the OOPIF is considered equally weighed as the renderer for the main frame. In reality, though, most if not all of the user input will be processed by the main frame, so the reported EQT should still be x.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a35d664b7ee32f32f8856280434be4274cae7f

commit 75a35d664b7ee32f32f8856280434be4274cae7f
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Apr 05 20:13:44 2018

Do not report EQT in OOPIF-only renderers

This CL allows the PageScheduler to know whether its main frame is local or
remote. If a renderer process has no local main frame, we do not report the
Expected Queueing Time.

Bug:  826753 
Change-Id: I92a0ccd54d820778e769bf3f2f24c3a22e3cc42a
Reviewed-on: https://chromium-review.googlesource.com/984296
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548536}
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/content/renderer/render_widget.cc
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/content/renderer/render_widget.h
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/core/exported/WebFrame.cpp
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.cc
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/platform/scheduler/main_thread/main_thread_scheduler.h
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/platform/scheduler/main_thread/page_scheduler_impl.h
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/platform/scheduler/public/page_scheduler.h
[modify] https://crrev.com/75a35d664b7ee32f32f8856280434be4274cae7f/third_party/WebKit/Source/platform/scheduler/test/fake_page_scheduler.h

Comment 2 by npm@chromium.org, Apr 5 2018

Status: Fixed (was: Assigned)
Now that we report EQT only for renderers in charge of at least one main frame, marking this as Fixed.

Comment 3 by dcheng@chromium.org, May 16 2018

Components: Internals>Sandbox>SiteIsolation
►

Sign in to add a comment