New issue
Advanced search Search tips

Issue 826750 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] When a lot of tabs are open, two tabs (instead of one tab) are showing the close button

Project Member Reported by meh...@chromium.org, Mar 28 2018

Issue description

Chrome Version: Canary 67.0.3382.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable chrome://flags/#views-browser-windows
(2) Open a new window
(3) Shrink it to a smaller size
(4) Open a lot of tabs, so that the tab close buttons disappear

What is the expected result?
Only one tab should show the close button.

What happens instead?
Two tabs are showing the close button

A screenshot is attached.
 
Bildschirmfoto 2018-03-27 um 23.04.54.png
59.1 KB View Download

Comment 1 Deleted

Labels: M-68 Target-68
Owner: weili@chromium.org
Status: Assigned (was: Available)
It actually seems like a random subset of the tabs show the close button versus the title, which is weird.

weili@, can you figure out how to make this consistent? Let's only show the close button for the frontmost tab.

Comment 3 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Comment 4 by weili@chromium.org, Mar 30 2018

Status: Started (was: Assigned)
Looks like this happens on all platforms. For tabs with regular websites, favicons will be shown instead of titles or close buttons when shrank. Since NTP has no favicon, it will have such problem. Working on it. 

Comment 5 by meh...@chromium.org, Mar 30 2018

Hello weili@, thanks looking into this issue.

One question: If possible, can you please also center the close button, when the tab is in the smallest state? As you can see in my screenshot from comment#0, the close button of the tab which is in the foreground is not correctly centered on the tab. If this should be tracked in another report, then please let me know, so that I can open it. Thank you :-)

Comment 6 by weili@chromium.org, Mar 30 2018

mehmet@, I checked on Canary 67.0.3384.0 and also ToT, looks like the position of the close button is now already centered. Pls let me know if you find otherwise. I can fix it if needed.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c622366bc98d65ee93cfe0b8a57a95cd9b8df39

commit 2c622366bc98d65ee93cfe0b8a57a95cd9b8df39
Author: Wei Li <weili@chromium.org>
Date: Thu Apr 05 17:00:22 2018

Show title in favor of close button on inactive tabs

For inactive tabs, we prefer showing favicon, then alert button,
then close button. When there is no favicon or alert button, we need
to show title first instead of the close button, so the tab can be
identified.

BUG= 826750 

Change-Id: I5148e13ce8faceff73ec73fede9d319422595685
Reviewed-on: https://chromium-review.googlesource.com/996809
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548456}
[modify] https://crrev.com/2c622366bc98d65ee93cfe0b8a57a95cd9b8df39/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/2c622366bc98d65ee93cfe0b8a57a95cd9b8df39/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/2c622366bc98d65ee93cfe0b8a57a95cd9b8df39/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/2c622366bc98d65ee93cfe0b8a57a95cd9b8df39/chrome/browser/ui/views/tabs/tab_strip_unittest.cc

Comment 8 by weili@chromium.org, Apr 5 2018

Status: Fixed (was: Started)
> mehmet@, I checked on Canary 67.0.3384.0 and also ToT, looks like the position of the close button is now already centered. Pls let me know if you find otherwise. I can fix it if needed.

Yes, thanks. It is already centered now.

And thanks that you have fixed the bug from this report :-)
Labels: Needs-Feedback
Tried checking the issue on reported chrome version 67.0.3382.0 using Mac 10.12.6 with the exact steps mentioned in comment#0.

We are unable to reproduce the issue on reported version itself. Attaching the screen cast of the same.

@Wei Li: Could you please have a look at the screen cast and let us know if we have missed anything in the process. Please help us in verifying the fix.
826750.mp4
1.6 MB View Download
vamshi.kommuri@, you may need to add more tabs until you see the issue. Also, when too many tabs added, you may also see all/most of them show close buttons as well. thanks

Sign in to add a comment