New issue
Advanced search Search tips

Issue 826745 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] The Default Profile Button is missing

Project Member Reported by meh...@chromium.org, Mar 28 2018

Issue description

Chrome Version: Canary 67.0.3382.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable chrome://flags/#views-browser-windows
(2) Open a new window
(3) Take a look at the right top corner

What is the expected result?
To see the default Profile Button

What happens instead?
A blank button when you hover at the place where you expect the profile button.

A screenshot is attached.
 
Bildschirmfoto 2018-03-28 um 17.59.11.png
73.8 KB View Download

Comment 1 by lgrey@chromium.org, Mar 28 2018

Labels: MacViews-Browser
Status: Available (was: Untriaged)
Confirmed with a clean --user-data-dir. It *does* show up for the Guest profile, so I think we're just missing a condition somewhere.
Labels: Target-67 M-67
Owner: lgrey@chromium.org
Status: Assigned (was: Available)
Over to lgrey@ - I think this will be a fairly simple fix.

Comment 3 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

There are only two M67 dev releases left on 04/03 & 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57808cf8c4abcb6a73f1e66aa267efa1935f7196

commit 57808cf8c4abcb6a73f1e66aa267efa1935f7196
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Mar 30 18:31:53 2018

MacViews: Implement generic avatar button

Bug:  826745 
Change-Id: I635382607d4c39e04a51cc628f71d045f4e5dcd1
Reviewed-on: https://chromium-review.googlesource.com/987528
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547215}
[modify] https://crrev.com/57808cf8c4abcb6a73f1e66aa267efa1935f7196/chrome/browser/ui/views/profiles/avatar_button.cc

Comment 5 by gov...@chromium.org, Mar 30 2018

If nothing is pending, can this be marked as fixed?

Comment 6 by lgrey@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)
Labels: TE-Verified-M67 TE-Verified-67.0.3386.0
Able to reproduce the issue on chrome reported version Canary 67.0.3382.0
Verified the fix on Mac 10.12.6 on Chrome version #67.0.3386.0 as per the comment#0
Attaching screen cast for reference.
Observed "Seen the default Profile Button"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
826745.mp4
567 KB View Download

Sign in to add a comment