New issue
Advanced search Search tips

Issue 826744 link

Starred by 1 user
Status: Fixed
Owner:
rhalavati@chromium.org
Closed: Apr 2018
Cc:
msramek@chromium.org
emaxx@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Traffic annotation validation failing

Project Member Reported by msramek@chromium.org, Mar 28 2018 
DCHECK(is_valid()) in net::MutableNetworkTrafficAnnotationTag has been failing for ~2 weeks, rendering some tests flaky. See e.g.  issue 822975  or  issue 823077 .

The likely culprits are

https://chromium.googlesource.com/chromium/src/+/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363
https://chromium.googlesource.com/chromium/src/+/921731ea1b3df56cee22f7a9268505cae56b7a90

which means that the cause is in the network codebase, and not in the affected tests.

To avoid causing test failures in unrelated codebases, annotation validation should be disabled while the culprit code is being investigated.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abbbd7058b0944fec94a0f55dd877aff7d189aff

commit abbbd7058b0944fec94a0f55dd877aff7d189aff
Author: Martin Sramek <msramek@chromium.org>
Date: Wed Mar 28 22:08:34 2018

Temporarily disable the failing traffic annotation validation

Until the issue can be investigated. This affected several unrelated tests.

Bug:  826744 
Change-Id: Ie955d68a72e7843b728c3d8172270958b893d3e4
Reviewed-on: https://chromium-review.googlesource.com/984355
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546615}
[modify] https://crrev.com/abbbd7058b0944fec94a0f55dd877aff7d189aff/net/traffic_annotation/network_traffic_annotation.h

Comment 2 by rhalavati@chromium.org, Apr 4 2018

Cc: -rhalavati@chromium.org
Owner: rhalavati@chromium.org
Status: Started (was: Assigned)
Thanks Martin.

I start working on it.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4196b8354cd1bf4aed168dfc0f21074893059303

commit 4196b8354cd1bf4aed168dfc0f21074893059303
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Apr 09 08:55:34 2018

Fix ProxyResolutionService annotation bug and reactivate tests.

Network traffic annotation in ProxyResolutionService was wrongly set in
cases where proxy info was fetched through completely synchronous
method, causing flaky test failures.
The bug is fixed and tests are re-enabled.

Bug:  822975 
Bug:  826744 
Bug:  823077 
Change-Id: Ic63301ff053fc9160b1a96372af1ee289342396c
Reviewed-on: https://chromium-review.googlesource.com/997656
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549130}
[modify] https://crrev.com/4196b8354cd1bf4aed168dfc0f21074893059303/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/4196b8354cd1bf4aed168dfc0f21074893059303/net/proxy_resolution/proxy_resolution_service.cc
[modify] https://crrev.com/4196b8354cd1bf4aed168dfc0f21074893059303/net/traffic_annotation/network_traffic_annotation.h

Comment 4 by rhalavati@chromium.org, Apr 10 2018

Status: Fixed (was: Started)
There seems to be no more errors. Marking it fixed.
►

Sign in to add a comment