New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826725 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in webrtc::RtpTransport::OnWritableState

Project Member Reported by ClusterFuzz, Mar 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5083459614408704

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0xf1116fc0
Crash State:
  webrtc::RtpTransport::OnWritableState
  void sigslot::_opaque_connection::emitter<webrtc::RtpTransport, rtc::PacketTrans
  cricket::DtlsTransport::set_writable
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=546387:546391

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5083459614408704

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 28 2018

Cc: zhihuang@webrtc.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Reland "Replace BundleFilter with RtpDemuxer in RtpTransport." by zhihuang@webrtc.org - https://webrtc.googlesource.com/src/+/27f3bf512827b483f9e0c67ce76362d83faa1950

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.

Comment 3 by zhihuang@webrtc.org, Mar 29 2018

Reverting the original change.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 29 2018

Labels: M-67
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 29 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 29 2018

Labels: Pri-1

Comment 7 by mmoroz@chromium.org, Mar 30 2018

Owner: zhihuang@chromium.org
Status: Assigned (was: Untriaged)

Comment 8 by mmoroz@chromium.org, Mar 30 2018

Components: Blink>WebRTC
Project Member

Comment 9 by ClusterFuzz, Mar 30 2018

ClusterFuzz has detected this issue as fixed in range 546863:546891.

Detailed report: https://clusterfuzz.com/testcase?key=5083459614408704

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0xf1116fc0
Crash State:
  webrtc::RtpTransport::OnWritableState
  void sigslot::_opaque_connection::emitter<webrtc::RtpTransport, rtc::PacketTrans
  cricket::DtlsTransport::set_writable
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=546387:546391
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=546863:546891

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5083459614408704

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Mar 30 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5083459614408704 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 30 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
 Issue 827550  has been merged into this issue.
Project Member

Comment 13 by ClusterFuzz, Mar 30 2018

Labels: OS-Chrome OS-Mac
Labels: -ReleaseBlock-Stable
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 6

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment