Issue 826719  has been merged into this issue.

Failing test CFIBacktraceAndroidTest.TestUnwinding was added by CL https://chromium-review.googlesource.com/c/chromium/src/+/958326 in blame list. Will revert.

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FAndroid_CFI%2F452%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests_on_Android%2F0%2Flogs%2FCFIBacktraceAndroidTest.TestUnwinding%2F0

base unittests passing

The test is failing again.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e34f08fadd179214d7da6c4160c538a6b882d97d

commit e34f08fadd179214d7da6c4160c538a6b882d97d
Author: Mikel Astiz <mastiz@chromium.org>
Date: Fri Apr 06 13:42:35 2018

Revert "Fix conditions for can_unwind_with_cfi_table with frame pointers"

This reverts commit 5e4c7d7b030455dcfc91245c3d6f673e35b7a3d5.

Reason for revert: 
Speculative revert for failing base_unittests on Android,
CFIBacktraceAndroidTest.TestUnwinding.

See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579

Original change's description:
> Fix conditions for can_unwind_with_cfi_table with frame pointers
> 
> CFI table unwinder is not appilcable for builds with frame pointer
> enabled. Make sure can_unwind_with_cfi_table is set to false.
> No need to check for use_thin_lto.
> 
> BUG=469376
> 
> Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6
> Reviewed-on: https://chromium-review.googlesource.com/992890
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548634}

TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org

Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 469376, 826718 
Reviewed-on: https://chromium-review.googlesource.com/999635
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548765}
[modify] https://crrev.com/e34f08fadd179214d7da6c4160c538a6b882d97d/build/config/compiler/compiler.gni

The speculative revert appears to have worked, closing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03d58e81dc74ca76cd83e1fe9778baf9bbe99f19

commit 03d58e81dc74ca76cd83e1fe9778baf9bbe99f19
Author: Siddhartha <ssid@chromium.org>
Date: Tue Apr 24 21:34:54 2018

Reland "Fix conditions for can_unwind_with_cfi_table with frame pointers"

This reverts commit e34f08fadd179214d7da6c4160c538a6b882d97d.

Reason for revert: using_sanitizer should also set enable_frame_pointer on android.
The cfi bot was broken because it enabled cfi unwinding with frame pointers.

Original change's description:
> Revert "Fix conditions for can_unwind_with_cfi_table with frame pointers"
>
> This reverts commit 5e4c7d7b030455dcfc91245c3d6f673e35b7a3d5.
>
> Reason for revert:
> Speculative revert for failing base_unittests on Android,
> CFIBacktraceAndroidTest.TestUnwinding.
>
> See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579
>
> Original change's description:
> > Fix conditions for can_unwind_with_cfi_table with frame pointers
> >
> > CFI table unwinder is not appilcable for builds with frame pointer
> > enabled. Make sure can_unwind_with_cfi_table is set to false.
> > No need to check for use_thin_lto.
> >
> > BUG=469376
> >
> > Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6
> > Reviewed-on: https://chromium-review.googlesource.com/992890
> > Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#548634}
>
> TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org
>
> Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 469376, 826718 
> Reviewed-on: https://chromium-review.googlesource.com/999635
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548765}

Change-Id: Ic6637dfe890a51264f9d151a681534fe92fc9354
Bug: 469376,  826718 
Reviewed-on: https://chromium-review.googlesource.com/1000412
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553287}
[modify] https://crrev.com/03d58e81dc74ca76cd83e1fe9778baf9bbe99f19/build/config/compiler/compiler.gni