New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5mb regression in resource_sizes (MonochromePublic.apk) at 546425:546425

Project Member Reported by agrieve@chromium.org, Mar 28 2018

Issue description

Caused by: 
Enable extracting unwind table on official builds without channel

https://chromium-review.googlesource.com/c/chromium/src/+/976944

 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 28 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=826717

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d215025f14fbf0aa26eebd073ffe54eaba9edb1dbf50cb3d8b3ea3cf3ea4e077


Bot(s) for this bug's original alert(s):

Android Builder
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 28 2018

Assigning to ssid@chromium.org because this is the only CL in range:
Enable extracting unwind table on official builds without channel

This CL enables extraction of unwind tables for chrome when
is_official_build is set to true and when android_channel is not set to
a release channel. This affects build time only on official builds.
Also, Set legacy heap profiler to use unwinder for profiling.

TBR=dpranke@chromium.org
BUG=819888

Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244
Reviewed-on: https://chromium-review.googlesource.com/976944
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546425}
ssid - The non-channel official build is what we monitor for binary size. Looks like this increased it by 5mb (more than expected?)

Would it be okay to enable the stack info for canary / dev, but not for no-channel?
Status: Fixed (was: Assigned)
CL got reverted:
a2474b6490ea9cfda76528059fbf23369e7d281f

Comment 5 by ssid@chromium.org, Mar 28 2018

Status: Started (was: Fixed)
I made the change with is_official_build for 
1. I was hoping to test locally using the is_official_build flag before releasing to canary / dev.
2. It is also good to monitor the size of the unwind table file in the binary size tester to make sure we see expected increase.

The increase will be 2MB once the compact format lands. I will get hopefully land it in few days.

Comment 6 by ssid@chromium.org, Mar 30 2018

Cc: mariakho...@chromium.org
So, the new graph shows 1.9MB regression which is as expected.
https://chromeperf.appspot.com/group_report?sid=d215025f14fbf0aa26eebd073ffe54eaba9edb1dbf50cb3d8b3ea3cf3ea4e077

Comment 7 by ssid@chromium.org, Apr 20 2018

Status: Fixed (was: Started)

Sign in to add a comment