Issue metadata
Sign in to add a comment
|
5mb regression in resource_sizes (MonochromePublic.apk) at 546425:546425 |
||||||||||||||||||||
Issue descriptionCaused by: Enable extracting unwind table on official builds without channel https://chromium-review.googlesource.com/c/chromium/src/+/976944
,
Mar 28 2018
Assigning to ssid@chromium.org because this is the only CL in range: Enable extracting unwind table on official builds without channel This CL enables extraction of unwind tables for chrome when is_official_build is set to true and when android_channel is not set to a release channel. This affects build time only on official builds. Also, Set legacy heap profiler to use unwinder for profiling. TBR=dpranke@chromium.org BUG=819888 Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244 Reviewed-on: https://chromium-review.googlesource.com/976944 Reviewed-by: Siddhartha S <ssid@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#546425}
,
Mar 28 2018
ssid - The non-channel official build is what we monitor for binary size. Looks like this increased it by 5mb (more than expected?) Would it be okay to enable the stack info for canary / dev, but not for no-channel?
,
Mar 28 2018
,
Mar 28 2018
I made the change with is_official_build for 1. I was hoping to test locally using the is_official_build flag before releasing to canary / dev. 2. It is also good to monitor the size of the unwind table file in the binary size tester to make sure we see expected increase. The increase will be 2MB once the compact format lands. I will get hopefully land it in few days.
,
Mar 30 2018
So, the new graph shows 1.9MB regression which is as expected. https://chromeperf.appspot.com/group_report?sid=d215025f14fbf0aa26eebd073ffe54eaba9edb1dbf50cb3d8b3ea3cf3ea4e077
,
Apr 20 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 28 2018