Show Cancel button when a task is running |
||
Issue description
When looking at a task;
- If PENDING, show 'cancel' button as previously
- If RUNNING, show 'cancel' button, with POST data {'kill_running':true}.
No change to tasklist.
The idea is that a user is looking at a pending task and cancels it, if the task switched to running the task will not be forcibly killed. But if the task is running, the task can be forcibly cancelled.
Do not show the button on the task list page, as killing a running task has side effects.
Ref:
https://cs.chromium.org/chromium/infra/luci/appengine/swarming/ui/res/imp/taskpage/task-page.html?l=965
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/975f35ae019637350ead376a6e1452c627ee6642 commit 975f35ae019637350ead376a6e1452c627ee6642 Author: Kevin Lubick <kjlubick@google.com> Date: Fri Mar 30 20:00:07 2018 Add cancel task button for running tasks Bug: 826708 Change-Id: I3505455cece2c8c9d5a19768fb91fb1c5d553bc6 Reviewed-on: https://chromium-review.googlesource.com/988374 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/975f35ae019637350ead376a6e1452c627ee6642/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/975f35ae019637350ead376a6e1452c627ee6642/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Apr 5 2018
This is live |
||
►
Sign in to add a comment |
||
Comment 1 by kjlubick@chromium.org
, Mar 30 2018Owner: kjlubick@chromium.org
Status: Started (was: Available)