Add new flag to buildbucket to cancel running tasks |
|||
Issue description
Running tasks are not cancelled unless {'kill_running':true} is passed as the post data.
You may want to surface this at the buildbucket API too, so that by default running tasks are not cancelled.
Or you may just always forcibly cancel tasks and accept the side-effects.
Ref:
cancel_task_async() in swarming.py.
https://cs.chromium.org/chromium/infra/appengine/cr-buildbucket/swarming/swarming.py?q=swarming/swarming.py&sq=package:chromium&l=773
,
Mar 28 2018
https://chromium-review.googlesource.com/c/infra/infra/+/984597
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/7030d232647f453c5d9dfa15e18ed43efa2eef41 commit 7030d232647f453c5d9dfa15e18ed43efa2eef41 Author: Nodir Turakulov <nodir@google.com> Date: Tue Apr 03 19:00:04 2018 [buildbucket] pass kill_running when canceling a task Bug: 826706 Change-Id: I571ddb38c656176e283a6024f7b0aac47cebbf61 Reviewed-on: https://chromium-review.googlesource.com/984597 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/7030d232647f453c5d9dfa15e18ed43efa2eef41/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/7030d232647f453c5d9dfa15e18ed43efa2eef41/appengine/cr-buildbucket/swarming/test/swarming_test.py
,
Apr 24 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mar...@chromium.org
, Mar 28 2018