New issue
Advanced search Search tips

Issue 826683 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 826656
issue 827610
issue 827611
issue 827810



Sign in to add a comment

Roll Clang again

Project Member Reported by h...@chromium.org, Mar 28 2018

Issue description

Tracking bug for the next Clang roll.
The previous roll as  https://crbug.com/823655 
 

Comment 1 by h...@chromium.org, Mar 28 2018

Blockedon: 826656

Comment 2 by p...@chromium.org, Mar 30 2018

Blocking: 801601

Comment 3 by p...@chromium.org, Mar 30 2018

Want r328905 for  issue 801601 .

Comment 4 by thakis@chromium.org, Mar 30 2018

Blockedon: 827610 827611
Cc: thomasanderson@chromium.org
thomasanderson gave this a try at https://chromium-review.googlesource.com/c/987232/ for r328716 for  issue 801925  and discovered that the mac_upload_clang bot is in not so great shape. Eventually the build made it through (but before 328905; maybe that'll be in a later roll) so those are not hard blockers, but it succeeded in 1 of 6 builds, which is pretty annoying if not fixed.
Is LLVM r328716 good for the next roll (we already have binaries for those, but they're not yet CQ tested)?  Or do we want to try something closer to ToT?

Comment 6 by thakis@chromium.org, Mar 30 2018

That's fine if it passes trybots. The less time between rolls the better :-)

Comment 7 by r...@chromium.org, Mar 31 2018

Blockedon: 827810
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af64dfd7fa5f5c954935d8350f4ad3b751a30361

commit af64dfd7fa5f5c954935d8350f4ad3b751a30361
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Apr 03 12:07:20 2018

Roll clang 328575:328716.

Ran `tools/clang/scripts/upload_revision.py 328716`.

BUG= 826683 

Change-Id: I1a5d85b42cdc4b98919345d442e1ddad328840b4
Reviewed-on: https://chromium-review.googlesource.com/987232
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547675}
[modify] https://crrev.com/af64dfd7fa5f5c954935d8350f4ad3b751a30361/tools/clang/scripts/update.py

Cc: inglorion@chromium.org
Owner: thomasanderson@chromium.org
Status: Fixed (was: Assigned)
Blocking: -801601
Next roll:  bug 828582 

Sign in to add a comment