New issue
Advanced search Search tips

Issue 826663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename webauth.mojom and password_manager.mojom to blink.mojom

Project Member Reported by engedy@chromium.org, Mar 28 2018

Issue description

By convention, Mojo interaces defined in Source/modules are in the blink.mojom namespace.
 

Comment 1 by engedy@chromium.org, Mar 31 2018

Labels: M-68
Owner: ----
Status: Available (was: Assigned)
Labels: -M-68 Hotlist-WebAuthnFixit M-69
Owner: eui-sang.lim@samsung.com
Status: Started (was: Available)
I'm working on password_manager.mojom.
https://chromium-review.googlesource.com/c/chromium/src/+/1136341

I'll take care of webauth.mojom once the above patch is merged.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeacdd2c69414ab35210dc5de513f95408f210a2

commit eeacdd2c69414ab35210dc5de513f95408f210a2
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Mon Jul 16 14:50:50 2018

Move CredentialManager interface into blink.mojom namespace

Rename password_manager.mojom to blink.mojom.
By convention, Mojo interaces defined in Source/modules
are in the blink.mojom namespace.

Bug:  826663 
Change-Id: I079229d0200e8d6daac3bcfc58cae147df182aaf
Reviewed-on: https://chromium-review.googlesource.com/1136341
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#575258}
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/components/password_manager/content/browser/content_credential_manager.cc
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/components/password_manager/content/browser/content_credential_manager.h
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/components/password_manager/content/common/credential_manager.typemap
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/components/password_manager/content/common/credential_manager_mojom_traits.cc
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/components/password_manager/content/common/credential_manager_mojom_traits.h
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-errors.html
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/mock-navigator-credentials.js
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/blink/public/platform/modules/credentialmanager/credential_manager.mojom
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/blink/renderer/modules/credentialmanager/credential_manager_proxy.h
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/blink/renderer/modules/credentialmanager/credential_manager_type_converters.cc
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/blink/renderer/modules/credentialmanager/credential_manager_type_converters.h
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc
[modify] https://crrev.com/eeacdd2c69414ab35210dc5de513f95408f210a2/third_party/blink/renderer/modules/credentialmanager/credentials_container_test.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2

commit dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Thu Jul 19 22:14:32 2018

Move Authenticator interface into blink.mojom namespace

Rename webauth.mojom and webauth.test.mojom to blink.mojom
and blink.test.mojom. By convention, Mojo interaces defined
in Source/modules are in the blink.mojom namespace.

Bug:  826663 
Change-Id: I85fc8e93ea940b91968e935ba0015ac76c9148c8
Reviewed-on: https://chromium-review.googlesource.com/1139454
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#576659}
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/android/java/src/org/chromium/chrome/browser/webauth/AuthenticatorFactory.java
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/android/java/src/org/chromium/chrome/browser/webauth/AuthenticatorImpl.java
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/android/java/src/org/chromium/chrome/browser/webauth/Fido2ApiHandler.java
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/android/java/src/org/chromium/chrome/browser/webauth/HandlerResponseCallback.java
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/android/javatests/src/org/chromium/chrome/browser/webauth/AuthenticatorTest.java
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/chrome/browser/chrome_content_browser_client.cc
[delete] https://crrev.com/50dde4e93eb084c64fd690700560d2cbc538837e/chrome/test/data/xr/webvr_info
[delete] https://crrev.com/50dde4e93eb084c64fd690700560d2cbc538837e/chrome/test/data/xr/webxr_samples
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/authenticator_type_converters.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/authenticator_type_converters.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/scoped_virtual_authenticator_environment.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/scoped_virtual_authenticator_environment.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/virtual_authenticator.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/virtual_authenticator.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/browser/webauth/webauth_browsertest.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/mock-navigator-credentials.js
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-create-helper.html
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-get-helper.html
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/virtual-navigator-credentials.js
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/blink/public/platform/modules/webauth/authenticator.mojom
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/blink/public/platform/modules/webauth/virtual_authenticator.mojom
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/blink/renderer/modules/credentialmanager/credential_manager_proxy.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/blink/renderer/modules/credentialmanager/credential_manager_type_converters.cc
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/blink/renderer/modules/credentialmanager/credential_manager_type_converters.h
[modify] https://crrev.com/dddb69907bcdf0f2fdd5bd0ed58ca2c8e9ca58a2/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/5c668f813d1b6f98808ac89507c8fdb838326b59

commit 5c668f813d1b6f98808ac89507c8fdb838326b59
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Fri Jul 20 11:57:28 2018

Sign in to add a comment