New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826657 link

Starred by 0 users
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Fuzz FormStructure::ParseFieldTypesFromAutocompleteAttributes

Project Member Reported by vabr@chromium.org, Mar 28 2018 
As I start ramping up to introduce browser-side form parsing for passwords, I spotted that the related FormStructure::ParseFieldTypesFromAutocompleteAttributes could use a bit of a clarification and would probably also benefit from being fuzzed. This bug tracks that work.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cebad6f03a7022365e85a43de559fbfa6a4e7c64

commit cebad6f03a7022365e85a43de559fbfa6a4e7c64
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Mar 28 16:21:33 2018

Polish FormStructure::ParseFieldTypesFromAutocompleteAttributes

After past surgeries, some comments in
ParseFieldTypesFromAutocompleteAttributes seem misplaced.

This CL does some unsubstantial polishing, including:
 * Putting comments in the correct order.
 * Enhancing comments about parsing.
 * Clarifying the const-ness of one type.
 * Avoiding one string allocation by using StringPiece.

The CL should not have any effect on Chrome's function.

Bug:  826657 
Change-Id: I9be4cb3723f92959c3e5a9d2259708d1a90bbf28
Reviewed-on: https://chromium-review.googlesource.com/983416
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546513}
[modify] https://crrev.com/cebad6f03a7022365e85a43de559fbfa6a4e7c64/components/autofill/core/browser/form_structure.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f

commit 2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Mar 28 18:37:19 2018

Fuzz ParseFieldTypesFromAutocompleteAttributes

This CL introduces a fuzzer for
FormStructure::ParseFieldTypesFromAutocompleteAttributes.

Bug:  826657 
Change-Id: I60a11c2a52e48c80000ab60b5941c4b3e233fb4e
Reviewed-on: https://chromium-review.googlesource.com/983954
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546553}
[modify] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/BUILD.gn
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer.cc
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer.dict
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer_corpus/address1
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer_corpus/address2
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer_corpus/username1
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer_corpus/username2
[add] https://crrev.com/2f31e5cb84484af3a2f8ffb33c82126ae97a0c0f/components/autofill/core/browser/form_structure_fuzzer_corpus/username3

Comment 3 by vabr@chromium.org, Mar 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment