New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826654 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ qi1988.y...@samsung.com
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted selection of Username is seen on chrome://settings/passwords

Reported by shruti.j...@etouch.net, Mar 28 2018 
Chrome version: 67.0.3382.0 (Official Build) Revision148f8c6decc123bb840a37b013caa8eed27759fd-refs/heads/master@{#546346}(32/64-bit)

OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.4)
 
Steps to reproduce:
1. Launch chrome and navigate to chrome://settings/passwords.
2. Press Tab until focus reaches ‘More actions’ icon.
3. Hit Tab Key once more  and observe.

Actual Result:Unwanted selection of Username is seen on pressing tab multiple times.

Expected Result:Username should not be selected, on pressing tab multiple times.

This is a regression issue broken in “M-67”and will soon update other info

Good Build:67.0.3379.0

Bad Build:67.0.3381.0

Note:After step 3 Focus shifts on ‘Chrome chip’ in omni-box, but unnecessarily username text selection is seen.

Thank You!
Actual.mov
5.5 MB View Download
Expected.mov
5.1 MB View Download

Comment 1 by shruti.j...@etouch.net, Mar 28 2018

Cc: qi1988.y...@samsung.com
Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 and providing the bisect using per-revision script:
Good Build : 67.0.3379.0 (Revision : 545320) 
Bad Build : 67.0.3381.0 (Revision : 545908)

You are probably looking for a change made after 545676 (known good), but no later than 545677 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0e730cbd89e2f054b910d11481debcc826792e93..132ebcfe843381df99f3309260c3badff8520140

Suspect:https://chromium.googlesource.com/chromium/src/+/132ebcfe843381df99f3309260c3badff8520140

@qi1988.yang:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note:Login with the valid credentials is pre-condition.
Kindly refer the attached video.

Thank You!
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed277b07144d2ed92560cca02e07f916817123dc

commit ed277b07144d2ed92560cca02e07f916817123dc
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Mar 30 03:13:53 2018

Fix regression: Make username not tab-focusable in passwords page.

Clicking with mouse will still expand username if it had been shortened
by ellipsis.
Username can still be focused with a screen reader.

Bug:  826654 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia77fa1f5ac6b90a9b97102ea4724df7d9f308a41
Reviewed-on: https://chromium-review.googlesource.com/984521
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547098}
[modify] https://crrev.com/ed277b07144d2ed92560cca02e07f916817123dc/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html

Comment 3 by hcarmona@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)

Comment 4 by shruti.j...@etouch.net, Apr 2 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3386.0
Update : 
Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS )and Mac(10.12.6, 10.13.1, 10.13.4) OS using latest Canary #67.0.3386.0 and issue is fixed.Kindly review the attached screen-cast.

Thank you!
Canary_Behaviour#67.0.3386.0.mov
5.3 MB View Download
►

Sign in to add a comment