New issue
Advanced search Search tips

Issue 826634 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in content::BlinkTestController::OnInitiateCaptureDump

Project Member Reported by ClusterFuzz, Mar 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5135103240699904

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  content::BlinkTestController::OnInitiateCaptureDump
  DispatchToMethodImpl<content::LayoutTestMessageFilter *, void
  DispatchToMethod<content::LayoutTestMessageFilter *, void
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=545879:545880

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5135103240699904

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 28 2018

Components: Internals>Core Test
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 28 2018

Labels: Test-Predator-Auto-Owner
Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/279708b3c8ed5b6d9b4ed452072458cb0f9047d0 ([LayoutTests] Replace multiple dump responses with one callback/struct.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47f15187b0e43076e770e6a052c72612030d09f5

commit 47f15187b0e43076e770e6a052c72612030d09f5
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Thu Mar 29 23:12:32 2018

[PE] Fix layout test controller crash when window is closed.

This patch ensures that we don't try to initiate a capture dump when
the main window has been discarded. Specifically, we would enter a
test_phase_ = CLEAN_UP in this case, and we should only be reporting
results if we're in DURING_TEST phase.

Bug:  826649 ,  826634 
Change-Id: Id0a4892a29b1e9b6bf4adb4ca6196c86da8cd071
Reviewed-on: https://chromium-review.googlesource.com/986944
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547007}
[modify] https://crrev.com/47f15187b0e43076e770e6a052c72612030d09f5/content/shell/browser/layout_test/blink_test_controller.cc

Project Member

Comment 4 by ClusterFuzz, Mar 30 2018

ClusterFuzz has detected this issue as fixed in range 547006:547009.

Detailed report: https://clusterfuzz.com/testcase?key=5135103240699904

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  content::BlinkTestController::OnInitiateCaptureDump
  DispatchToMethodImpl<content::LayoutTestMessageFilter *, void
  DispatchToMethod<content::LayoutTestMessageFilter *, void
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=545879:545880
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=547006:547009

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5135103240699904

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Mar 30 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5135103240699904 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment