createRadialGradient fills whole fillRect area
Reported by
d4niel.h...@gmail.com,
Mar 28 2018
|
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Steps to reproduce the problem: 1. Open Chrome 65 / 66 (Beta) 2. Visit https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/createRadialGradient and scroll down to the example What is the expected behavior? The example should show a radial green to white radial gradient in the 200px/200px rectangle. What went wrong? The 200px/200px rectangle is all green. No gradient to white is visible. Did this work before? Yes Chrome 64 Chrome version: 65.0.3325.181 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: - Chrome Canary (67) doesn't seem to have this issue anymore. - Problem does also not occur when Canvas Hardware acceleration is disabled (but who wants to do that? ;-))
,
Mar 28 2018
I just played around with it a bit more. It seems like the issue is present when some of the parameters have/share the same values only: Working ------------------------------------------ - createRadialGradient(49,49,49,49,50,1) - createRadialGradient(50,50,50,49,50,1) Not working ------------------------------------------ - createRadialGradient(50,50,50,50,50,1) - createRadialGradient(49,50,50,49,50,1) For now I will just do this as a workaround.
,
Mar 28 2018
,
Mar 29 2018
Able to reproduce this issue on reported version 65.0.3325.181 and on latest beta 66.0.3359.66 using Windows 10, Mac 10.13.3 and Ubuntu 14.04. But issue is not reproducible on latest canary 67.0.3382.0. Hence providing reverse bisect info. Last Bad Build: 67.0.3375.0 First Good Build: 67.0.3377.0 You are probably looking for a change made after 544275 (known good), but no later than 544276 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a675d0718ef082318e0b5d025d9d7fe75af304be..120a10693da6c61782cf52e5c81fb30730362b37 Probably fixed by https://skia-review.googlesource.com/115042 or https://skia-review.googlesource.com/115162 from skia roll. @ liyuqian: Please confirm the bug and help in re-assigning if it is not related to your change. Please merge the fix to M-65 and M-66 if it is safe and if we have stable refresh. Adding RB-Stable for M-65. Please change if not the case. Thanks!
,
Mar 29 2018
Yes, this is the bug that https://skia-review.googlesource.com/115042 fixed and it should be merged into m65 in https://skia-review.googlesource.com/c/skia/+/117160 now. Please let me know if there's more that I should do.
,
Mar 29 2018
,
Mar 29 2018
M65 has been out since 03/06 and we're NOT planning any further M65 stable releases unless EXTREMELY critical issue arise, pls request a merge to M66 which is going to stable in few weeks. Thank you.
,
Mar 29 2018
NP, it's now merged into m66: https://skia-review.googlesource.com/c/skia/+/117242
,
Mar 30 2018
Thank you liyuqian@, did you request a merge to M66 or cl listed at #8 got merged without approval?
,
Apr 2 2018
I think a cherry-pick into chrome/m66 is automatically merged without approval. Do I need a manual merge action?
,
Apr 2 2018
liyuqian@ - before merging to a branch, you need to request merge approval. However, looking at the code change in #8, I'm fine with the merge. Can you please confirm if this is a safe merge overall and you've already verified this in canary/dev?
,
Apr 2 2018
Yes, I confirm that no suspicious crash reports are found in m67 with the CL.
,
Apr 2 2018
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks!
,
Apr 2 2018
Any else that I need to do other than confirming that this CL is safe to merge?
,
Apr 4 2018
There's a StackOverflow question (by me) about this issue here: https://stackoverflow.com/questions/49640841/canvas-createradialgradient-not-working-as-expected-in-chrome-v65
,
Apr 4 2018
Thank you Laust for updating the question with the fix info!
,
Apr 5 2018
Can I mark this as fixed now?
,
Apr 9 2018
Reminder: Please note that M66 Stable is only 7 days away. This bug has been marked as ReleaseBlock Stable for M66. So please take a look and appropriately address this bug.
,
Apr 10 2018
abdulsyed@, can you please confirm if the CL is merged and whether the problem is fixed?
,
Apr 12 2018
Looks like the change was merged to Skia in #8. You need to ensure that a merge is requested with the label Merge-Request-66 prior to merging. Can you please verify in the latest beta whether this is fixed?
,
Apr 13 2018
I confirm that the fix is in 66.0.3359.109 and the bug is fixed there.
,
Apr 13 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 13 2018
,
Apr 13 2018
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 13 2018
Already merged - so removing Merge-Request label.
,
Apr 13 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dtapu...@chromium.org
, Mar 28 2018