Audit uses of BrowserView::GetLocationBar{,View}() with DesktopPWAWindowing |
|||||
Issue descriptionSame deal as issue 826596 with BrowserView::toolbar(). Audit calls to BrowserView::GetLocationBarView() and BrowserView::GetLocationBar() to see if they should use BrowserView::button_provider() instead of assuming the tabbed UI toolbar is used. In hosted app windows the location bar may not be visible and page controls may live inside HostedAppButtonContainer instead.
,
Mar 28 2018
BrowserView::GetLocationBar() is an override of BrowserWindow::GetLocationBar() so that too will need auditing.
,
Mar 28 2018
BrowserView/BrowserWindow::GetLocationBar() call sites that probably need to change: SaveCardBubbleControllerImpl::UpdateIcon() https://cs.chromium.org/chromium/src/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc?l=360 Browser::RegisterProtocolHandler() https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?l=1779 Browser::Observe() https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?l=2080 ManagePasswordsUIController::UpdateBubbleAndIconVisibility() https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc?l=563 ZoomBubbleView::UpdateZoomIconVisibility() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc?l=522 BrowserView::GetLocationBarView() call sites that probably need to change: extension_installed_bubble_view.cc AnchorViewForBrowser https://cs.chromium.org/chromium/src/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc?l=101 BrowserView::ZoomChangedForActiveTab() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/browser_view.cc?l=836 BrowserView::FocusInactivePopupForAccessibility() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/browser_view.cc?l=1090 BrowserView::RotatePaneFocus() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/browser_view.cc?l=1118 BrowserView::ShowSaveCreditCardBubble() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/browser_view.cc?l=1210 zoom_bubble_view.cc GetAnchorViewForBrowser() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc?l=126 zoom_bubble_view.cc ParentToViewsBrowser() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc?l=164 page_info_bubble_view.cc ShowPageInfoDialogImpl() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/page_info/page_info_bubble_view.cc?l=1042 PasswordBubbleViewBase::ShowBubble() https://cs.chromium.org/chromium/src/chrome/browser/ui/views/passwords/password_bubble_view_base.cc?l=42
,
Mar 28 2018
Also: FindBarController::FindBarVisibilityChanged() https://cs.chromium.org/chromium/src/chrome/browser/ui/find_bar/find_bar_controller.cc?l=86
,
Apr 6 2018
Pushing back to P3 (this is less urgent than the other P2s).
,
Apr 13 2018
67 has branched, moving bugs over to 68.
,
Jun 18 2018
Bulk punting M68 PWA bugs to M69.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by alancutter@chromium.org
, Mar 28 2018