New issue
Advanced search Search tips

Issue 826579 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 668278



Sign in to add a comment

custom Windows 10 caption buttons are not quite right in hidpi.

Project Member Reported by bsep@chromium.org, Mar 28 2018

Issue description

Spinning this off of 554033, since we decided this is not longer a blocking issue.

The custom Windows 10 window controls are not the right size at hidpi. Windows has a different scaling algorithm than Chrome, which leads to the mismatch. See the TODO in Windows10CaptionButton::CalculatePreferredSize. They also are not always laid out exactly where they should be. Sometimes there's a slight gap between them and the window border.

Sometimes the close button's X is not aligned to pixels, and thus doesn't look right. See the TODO at the end of Windows10CaptionButton::PaintSymbol.
 

Comment 1 by osh...@chromium.org, Mar 28 2018

Cc: malaykeshav@chromium.org

Comment 2 by bsep@chromium.org, Mar 30 2018

This screenshot shows off all three issues:
* The buttons are 68 pixels wide, whereas Windows would draw them 69 pixels wide.
* There is a 1 pixel gap between the top of the button and the window frame border.
* The close button's X symbol is misaligned. The two lines should meet at a single pixel in the center.

Different scale factors have slightly different results, but the problem is rarely any worse than this.
hidpi-button-gap.PNG
4.9 KB View Download
What effect does enabling pixel canvas have on this?

Comment 4 by bsep@chromium.org, Mar 30 2018

#3: Looks to be the same, except that the minimize and maximize button symbols are now a bit wonky.
window-controls-pixel-canvas.PNG
5.0 KB View Download
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
***Mass UI Triage*** Adding related labels as per dev comments.

Sign in to add a comment