New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826576 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 15 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 822310



Sign in to add a comment

RobustResourceInitTest.ReuploadingClearsTexture failing on mac_optional_gpu_tests_rel

Project Member Reported by kbr@chromium.org, Mar 28 2018

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/683

RobustResourceInitTest.ReuploadingClearsTexture/ES3_OPENGL
RobustResourceInitTest.ReuploadingClearsTexture/ES2_OPENGL failed:

https://chromium-swarm.appspot.com/task?id=3c82b82c57af8010&refresh=10&show_raw=1

[ RUN      ] RobustResourceInitTest.ReuploadingClearsTexture/ES3_OPENGL
Received signal 11 <unknown> 000000000000
0   angle_end2end_tests                 0x00000001068f983c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   angle_end2end_tests                 0x00000001068f9671 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2401
2   libsystem_platform.dylib            0x00007fffd039cb3a _sigtramp + 26
3   ???                                 0x000000010cc3ff14 0x0 + 4509138708
4   GeForceGLDriver                     0x00007fffb6267d6a gldBlitFramebufferData + 5231
5   GeForceGLDriver                     0x00007fffb6267a97 gldBlitFramebufferData + 4508
6   GeForceGLDriver                     0x00007fffb625054e gldReadTextureData + 882892
7   libGPUSupportMercury.dylib          0x00007fffc86afbc4 gldUnbindFramebuffer + 73
8   GLEngine                            0x000000010b6b8735 gleUnbindAndFreeFramebufferObject + 108
9   GLEngine                            0x000000010b5f663f glDeleteFramebuffersEXT_Exec + 260
10  libGLESv2.dylib                     0x000000010799152b rx::StateManagerGL::deleteFramebuffer(unsigned int) + 123
11  libGLESv2.dylib                     0x000000010797fe0f rx::FramebufferGL::~FramebufferGL() + 31
12  libGLESv2.dylib                     0x000000010779e0df gl::Framebuffer::~Framebuffer() + 63
13  libGLESv2.dylib                     0x000000010779e1ae gl::Framebuffer::~Framebuffer() + 14
14  libGLESv2.dylib                     0x00000001077dac04 gl::TypedResourceManager<gl::Framebuffer, gl::HandleAllocator, gl::FramebufferManager>::deleteObject(gl::Context const*, unsigned int) + 100
15  libGLESv2.dylib                     0x0000000107778984 gl::Context::deleteFramebuffers(int, unsigned int const*) + 84
16  angle_end2end_tests                 0x00000001066c034e angle::RobustResourceInitTest::checkNonZeroPixels(angle::GLWrapper<&(glGenTextures), &(glDeleteTextures)>*, int, int, int, int, angle::GLColor const&) + 430
17  angle_end2end_tests                 0x00000001066c1047 angle::RobustResourceInitTest_ReuploadingClearsTexture_Test::TestBody() + 551
18  angle_end2end_tests                 0x00000001068cec16 testing::Test::Run() + 246
19  angle_end2end_tests                 0x00000001068cf820 testing::TestInfo::Run() + 288
20  angle_end2end_tests                 0x00000001068cfe47 testing::TestCase::Run() + 263
21  angle_end2end_tests                 0x00000001068dc597 testing::internal::UnitTestImpl::RunAllTests() + 855
22  angle_end2end_tests                 0x00000001068dc21e testing::UnitTest::Run() + 110


Geoff, this looks like a problem with the recent implementation of robust resource init in ANGLE's OpenGL backend. The CQ is hung up on this right now; could you please investigate this with high priority?

 
Test just needs to be skipped. Pretty good evidence we need to re-instate NVIDIA mac retina testing on the ANGLE CQ (issue 822310)
Cc: geoffl...@chromium.org
Owner: fjhenigman@chromium.org
Frank's still working now. Frank can you take care of skipping the broken tests on Mac?
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c7575da546a49152db47811416c62029f7c266ab

commit c7575da546a49152db47811416c62029f7c266ab
Author: Frank Henigman <fjhenigman@chromium.org>
Date: Wed Mar 28 02:17:44 2018

Skip ReuploadingClearsTexture test on Mac.

BUG= chromium:826576 

Change-Id: If241e57480efe3aabfb30a2be453f05d45367e4a
Reviewed-on: https://chromium-review.googlesource.com/982910
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/c7575da546a49152db47811416c62029f7c266ab/src/tests/gl_tests/RobustResourceInitTest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc736a1edf0d83aec5739f1e233652a9dfa3493

commit 5bc736a1edf0d83aec5739f1e233652a9dfa3493
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 28 05:33:50 2018

Roll src/third_party/angle/ e858cb1db..c7575da54 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/e858cb1db3c2..c7575da546a4

$ git log e858cb1db..c7575da54 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 fjhenigman Skip ReuploadingClearsTexture test on Mac.

Created with:
  roll-dep src/third_party/angle
BUG= chromium:826576 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: Ib4684041d6aeaa2fa405327fc19c0f4c9f27ab51
Reviewed-on: https://chromium-review.googlesource.com/983054
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546418}
[modify] https://crrev.com/5bc736a1edf0d83aec5739f1e233652a9dfa3493/DEPS

Comment 5 by kbr@chromium.org, Mar 28 2018

Blocking: 822310
Status: Verified (was: Assigned)
Jamie, good point about getting the NVIDIA Mac testers back on the ANGLE CQ.

Frank, thanks for quickly addressing this. Confirmed that patches are getting through mac_optional_gpu_tests_rel now.

Sign in to add a comment