New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826568 link

Starred by 1 user
Status: Fixed
Owner:
█ felixe@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
tbarzic@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SystemDisplayGetInfoFunction uses ShouldRestrictToKioskAndWebUI incorrectly

Project Member Reported by steve...@chromium.org, Mar 28 2018 
Discovered during a review of some system_display_api.cc related re-factoring.

In SystemDisplayGetInfoFunction::Response(), ShouldRestrictToKioskAndWebUI() is used (according to the comment) to limit edid data to kiosk mode, but the ShouldRestrictToKioskAndWebUI() method returns whether we need to test for kiosk mode, it does not actually perform the test. The test is in SystemDisplayFunction::PreRunValidation.

Comment 1 by tovep@chromium.org, Apr 3 2018

Labels: hotrod-platform-active
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52d8147416a1006b8fd50bc13bf6781bdf38fb7e

commit 52d8147416a1006b8fd50bc13bf6781bdf38fb7e
Author: Felix Ekblom <felixe@chromium.org>
Date: Wed Apr 04 19:05:32 2018

Actually check whether extension is in kiosk mode

Add the missing check for actually being in kiosk mode, but keep the
autotest bail to simplify testing of the feature.

BUG= chromium:826568 
TEST=Ran autotest, verified that extension can't access edid.

Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
Reviewed-on: https://chromium-review.googlesource.com/982619
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Felix Ekblom <felixe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548147}
[modify] https://crrev.com/52d8147416a1006b8fd50bc13bf6781bdf38fb7e/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/52d8147416a1006b8fd50bc13bf6781bdf38fb7e/extensions/browser/api/system_display/system_display_api.h
[modify] https://crrev.com/52d8147416a1006b8fd50bc13bf6781bdf38fb7e/extensions/browser/api/system_display/system_display_apitest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da9b99e1f9dad342507d4ef94b727d06a47826ef

commit da9b99e1f9dad342507d4ef94b727d06a47826ef
Author: Weidong Guo <weidongg@chromium.org>
Date: Thu Apr 05 02:56:35 2018

Revert "Actually check whether extension is in kiosk mode"

This reverts commit 52d8147416a1006b8fd50bc13bf6781bdf38fb7e.

Reason for revert: This causes display settings crash.  crbug.com/829190 

Original change's description:
> Actually check whether extension is in kiosk mode
> 
> Add the missing check for actually being in kiosk mode, but keep the
> autotest bail to simplify testing of the feature.
> 
> BUG= chromium:826568 
> TEST=Ran autotest, verified that extension can't access edid.
> 
> Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
> Reviewed-on: https://chromium-review.googlesource.com/982619
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548147}

TBR=stevenjb@chromium.org,felixe@chromium.org

Change-Id: I0c72734b027c4920eb4ab341ca0813c645870f6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:826568 
Reviewed-on: https://chromium-review.googlesource.com/996933
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548301}
[modify] https://crrev.com/da9b99e1f9dad342507d4ef94b727d06a47826ef/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/da9b99e1f9dad342507d4ef94b727d06a47826ef/extensions/browser/api/system_display/system_display_api.h
[modify] https://crrev.com/da9b99e1f9dad342507d4ef94b727d06a47826ef/extensions/browser/api/system_display/system_display_apitest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3af8152258a06e0a8116d7ba9cf7a4c0d930cd07

commit 3af8152258a06e0a8116d7ba9cf7a4c0d930cd07
Author: Felix Ekblom <felixe@chromium.org>
Date: Tue Apr 10 07:59:30 2018

Reland "Actually check whether extension is in kiosk mode"

This is a reland of 52d8147416a1006b8fd50bc13bf6781bdf38fb7e

Original change's description:
> Actually check whether extension is in kiosk mode
> 
> Add the missing check for actually being in kiosk mode, but keep the
> autotest bail to simplify testing of the feature.
> 
> BUG= chromium:826568 
> TEST=Ran autotest, verified that extension can't access edid.
> 
> Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
> Reviewed-on: https://chromium-review.googlesource.com/982619
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548147}

Bug:  chromium:826568 
Change-Id: I4a005a804d1de6325fb145f62e7d1d778ee5b201
Reviewed-on: https://chromium-review.googlesource.com/997412
Commit-Queue: Felix Ekblom <felixe@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549448}
[modify] https://crrev.com/3af8152258a06e0a8116d7ba9cf7a4c0d930cd07/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/3af8152258a06e0a8116d7ba9cf7a4c0d930cd07/extensions/browser/api/system_display/system_display_api.h
[modify] https://crrev.com/3af8152258a06e0a8116d7ba9cf7a4c0d930cd07/extensions/browser/api/system_display/system_display_apitest.cc

Comment 5 by felixe@chromium.org, Apr 10 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment