Widget/Omnibox Popup tests for 115% / 150% scale factors |
||
Issue descriptionChrome Version : 65.0.3325.181 OS Version: Windows 10.0 Issue 824627 and Issue 629363 document some troubling issues with obscure scale factors on Windows and the omnibox popup. Currently some tests set 2.0 for kForceDeviceScaleFactor, but no tests seem to attempt non-integral scale factors. When moving away from non-integral scale factors the test may also be subject to other bot screen metrics that could cause flakiness (e.g. a widget may get a different size, depending where its origin is). So I suspect this will be hard, have a high maintenance cost, and kForceDeviceScaleFactor may not even provide the right kind of test coverage. Still, it's worth a try..
,
Mar 28 2018
Initial attempt.... A browser test does not even get past PreMainMessageLoopRun with a 115% scale factor (150% works, but that wasn't what regressed in Issue 824627 ). [111702:111702:0328/114407.331954:FATAL:cursor_util.cc(130)] Check failed: total_width % frame_width == 0 (17 vs. 0) #0 0x7f62d9c40d5d base::debug::StackTrace::StackTrace() #1 0x7f62d9c3f46c base::debug::StackTrace::StackTrace() #2 0x7f62d9cbf11d logging::LogMessage::~LogMessage() #3 0x7f62d556392c ui::GetAnimatedCursorBitmaps() #4 0x7f62d556dca3 ui::CursorLoaderOzone::LoadAnimatedCursor() #5 0x7f62d557cf2c ui::ImageCursors::ReloadCursors() #6 0x7f62d557cc0a ui::ImageCursors::SetDisplay() #7 0x7f62d3efe111 ui::ws::(anonymous namespace)::SetDisplayOnResourceThread() #8 0x7f62d3f0077b _ZN4base8internal13FunctorTraitsIPFvNS_7WeakPtrIN2ui12ImageCursorsEEERKN7display7DisplayEfEvE6InvokeIJRKS5_S9_RKfEEEvSB_DpOT_ #9 0x7f62d3f00710 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvNS_7WeakPtrIN2ui12ImageCursorsEEERKN7display7DisplayEfEJRKS7_SB_RKfEEEvOT_DpOT0_ #10 0x7f62d3f006b0 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_7WeakPtrIN2ui12ImageCursorsEEERKN7display7DisplayEfEJS6_S8_fEEEFvvEE7RunImplIRKSC_RKNSt3__15tupleIJS6_S8_fEEEJLm0ELm1ELm2EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #11 0x7f62d3f0057c _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_7WeakPtrIN2ui12ImageCursorsEEERKN7display7DisplayEfEJS6_S8_fEEEFvvEE3RunEPNS0_13BindStateBaseE #12 0x7f62d9bf222e _ZNO4base12OnceCallbackIFvvEE3RunEv #13 0x7f62d9c4493a base::debug::TaskAnnotator::RunTask() #14 0x7f62d9cdd4ba base::internal::IncomingTaskQueue::RunTask() #15 0x7f62d9ce5a56 base::MessageLoop::RunTask() #16 0x7f62d9ce5ca5 base::MessageLoop::DeferOrRunPendingTask() #17 0x7f62d9ce5f84 base::MessageLoop::DoWork() #18 0x7f62d9ceadfb base::MessagePumpLibevent::Run() #19 0x7f62d9ce533a base::MessageLoop::Run() #20 0x7f62d9d9ab22 base::RunLoop::Run() #21 0x000007099f96 content::RunThisRunLoop() #22 0x00000709a15a content::RunAllPendingInMessageLoop() #23 0x000005ef391a InProcessBrowserTest::PreRunTestOnMainThread() #24 0x000006fee760 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #25 0x0000009b523d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_ #26 0x0000009b5184 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #27 0x000006ff1015 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #28 0x000006ff0f5c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #29 0x0000009974fd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #30 0x000005fe682c ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
,
Mar 28 2018
https://chromium-review.googlesource.com/983074 tests just 150%. I can't get it to fail on a ChromeOS developer build though. |
||
►
Sign in to add a comment |
||
Comment 1 by osh...@chromium.org
, Mar 28 2018