New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

PhysicalWeb cleanup

Project Member Reported by cco3@chromium.org, Mar 27 2018

Issue description

PhysicalWeb needs to be removed from Chromium on Android.  We no longer display PW URLs in the URL bar, and URL scanning/displaying is done by Google Nearby.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/fed8fae9726dd111af2c83b8304da469636bad41

commit fed8fae9726dd111af2c83b8304da469636bad41
Author: Conley Owens <cco3@google.com>
Date: Fri Mar 30 22:23:17 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba0affc52c5c49409e4b4151cf869c99ac5d5641

commit ba0affc52c5c49409e4b4151cf869c99ac5d5641
Author: Conley Owens <cco3@chromium.org>
Date: Wed Apr 04 17:39:39 2018

physicalweb: Remove share feature

Just one more step in Removing the Physical Web from Chrome.

BUG= 826540 

Change-Id: I6d413b2d0b3257a9d38a86ab09eb82ff0f42f127
Reviewed-on: https://chromium-review.googlesource.com/988804
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548118}
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/chrome/android/java/AndroidManifest.xml
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-hdpi/ic_image_white_24dp.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-hdpi/physical_web_notification_large.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-mdpi/ic_image_white_24dp.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-mdpi/physical_web_notification_large.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-xhdpi/ic_image_white_24dp.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-xhdpi/physical_web_notification_large.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-xxhdpi/ic_image_white_24dp.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-xxhdpi/physical_web_notification_large.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-xxxhdpi/ic_image_white_24dp.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/res/drawable-xxxhdpi/physical_web_notification_large.png
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareActivity.java
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareEntryActivity.java
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/chrome/android/java_sources.gni
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/chrome/browser/BUILD.gn
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/browser/android/physical_web/eddystone_encoder_bridge.cc
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/chrome/browser/android/physical_web/eddystone_encoder_bridge_unittest.cc
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/chrome/test/BUILD.gn
[modify] https://crrev.com/ba0affc52c5c49409e4b4151cf869c99ac5d5641/components/BUILD.gn
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/components/physical_web/eddystone/BUILD.gn
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/components/physical_web/eddystone/eddystone_encoder.cc
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/components/physical_web/eddystone/eddystone_encoder.h
[delete] https://crrev.com/7e57b2d6c8406a676967813822d0551d9b86005d/components/physical_web/eddystone/eddystone_encoder_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bdaddb5897ef414162975bb2851300bd38ef695

commit 5bdaddb5897ef414162975bb2851300bd38ef695
Author: Conley Owens <cco3@chromium.org>
Date: Mon Apr 09 22:15:23 2018

Remove the PhysicalWeb diagnostics page

Just one more step in Removing the Physical Web from Chrome.

BUG= 826540 

Change-Id: I617bfd3d82acae53f3654a59f51a03ff8c6b5f96
Reviewed-on: https://chromium-review.googlesource.com/988835
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549299}
[delete] https://crrev.com/95af9924b8c89c16a8d015dcb83fd70f74b85c1a/chrome/android/java/res/layout/physical_web_diagnostics.xml
[modify] https://crrev.com/5bdaddb5897ef414162975bb2851300bd38ef695/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/5bdaddb5897ef414162975bb2851300bd38ef695/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
[modify] https://crrev.com/5bdaddb5897ef414162975bb2851300bd38ef695/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
[delete] https://crrev.com/95af9924b8c89c16a8d015dcb83fd70f74b85c1a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
[modify] https://crrev.com/5bdaddb5897ef414162975bb2851300bd38ef695/chrome/android/java_sources.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/021570527933e7174e48b61f180bb24d99cbe4e4

commit 021570527933e7174e48b61f180bb24d99cbe4e4
Author: Conley Owens <cco3@chromium.org>
Date: Tue Apr 17 16:43:03 2018

physicalweb: Remove omnibox feature

Just one more step in Removing the Physical Web from Chrome.

BUG= 826540 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2b99e83a64a0c655c37569cb7d9f0924bbfb6948
Reviewed-on: https://chromium-review.googlesource.com/988954
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551360}
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/DEPS
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_classifier.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_controller.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_provider.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_provider.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/autocomplete_provider_client.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/mock_autocomplete_provider_client.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/components/omnibox/browser/omnibox_metrics_provider.cc
[delete] https://crrev.com/fc3376af153c6fbf8915b262dd9a86b6aaa23a41/components/omnibox/browser/physical_web_node.cc
[delete] https://crrev.com/fc3376af153c6fbf8915b262dd9a86b6aaa23a41/components/omnibox/browser/physical_web_node.h
[delete] https://crrev.com/fc3376af153c6fbf8915b262dd9a86b6aaa23a41/components/omnibox/browser/physical_web_provider.cc
[delete] https://crrev.com/fc3376af153c6fbf8915b262dd9a86b6aaa23a41/components/omnibox/browser/physical_web_provider.h
[delete] https://crrev.com/fc3376af153c6fbf8915b262dd9a86b6aaa23a41/components/omnibox/browser/physical_web_provider_unittest.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.h
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/ios/chrome/browser/ui/omnibox/autocomplete_match_formatter.mm
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/ios/chrome/browser/ui/omnibox/omnibox_util.cc
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[modify] https://crrev.com/021570527933e7174e48b61f180bb24d99cbe4e4/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31132ff90278c867c14815a7ff527a18da7a3060

commit 31132ff90278c867c14815a7ff527a18da7a3060
Author: Conley Owens <cco3@chromium.org>
Date: Fri Apr 20 20:15:57 2018

physicalweb: Remove Physical Web NTP snippets

This change removes the Physical Web from NTP snippets.

This feature was never enabled on Stable.  It only got to M57 Beta.

BUG= 826540 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4028c97771dfd325e3dd22f8ac57695a07b962c9
Reviewed-on: https://chromium-review.googlesource.com/1015720
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552447}
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/chrome/browser/ntp_snippets/dependent_features.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/category.h
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/category_rankers/constant_category_ranker.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/content_suggestions_metrics.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/features.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/features.h
[delete] https://crrev.com/cd9523cc319d7fa047bbcd908ed61b8acfb06924/components/ntp_snippets/physical_web_pages/DEPS
[delete] https://crrev.com/cd9523cc319d7fa047bbcd908ed61b8acfb06924/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
[delete] https://crrev.com/cd9523cc319d7fa047bbcd908ed61b8acfb06924/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
[delete] https://crrev.com/cd9523cc319d7fa047bbcd908ed61b8acfb06924/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/pref_names.cc
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/components/ntp_snippets/pref_names.h
[modify] https://crrev.com/31132ff90278c867c14815a7ff527a18da7a3060/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97

commit 43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97
Author: Conley Owens <cco3@chromium.org>
Date: Wed Apr 25 18:58:13 2018

physicalweb: Remove the privacy preference

This change removes the Physical Web privacy preference.

BUG= 826540 

Change-Id: I5bd06d3df7cb6e03051921a3c6d8d02b2c82b329
Reviewed-on: https://chromium-review.googlesource.com/1024756
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553687}
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java/res/values/values.xml
[delete] https://crrev.com/2e8f9e68a60274e9998173be8de305823815b561/chrome/android/java/res/xml/physical_web_preferences.xml
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java/res/xml/privacy_preferences.xml
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[delete] https://crrev.com/2e8f9e68a60274e9998173be8de305823815b561/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/43d41bed21f1cfe2a059d6d754ad5dbceb4b6d97/chrome/android/java_sources.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f1d03f83a2c98a244ded79468b7e056b121690

commit 64f1d03f83a2c98a244ded79468b7e056b121690
Author: Conley Owens <cco3@chromium.org>
Date: Fri Apr 27 19:28:45 2018

physicalweb: Remove Nearby-based scanning

This change removes all Play Services Nearby-based scanning from
chromium.

BUG= 826540 

Change-Id: Id7b8a31724ac81709e056617bf003d7d43d5991c
Reviewed-on: https://chromium-review.googlesource.com/1028512
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554447}
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/android/play_services/config.json
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/secondary/third_party/android_tools/BUILD.gn
[delete] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/build/secondary/third_party/android_tools/google_play_services_nearby_java.info
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/chrome/android/BUILD.gn
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[delete] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyBackgroundSubscription.java
[delete] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java
[delete] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyMessageIntentService.java
[delete] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbySubscription.java
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[delete] https://crrev.com/0ddbd0a3f170ec05598eec92b2dfdf105dac1c03/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java
[modify] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/chrome/android/java_sources.gni

Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699

commit a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699
Author: Conley Owens <cco3@chromium.org>
Date: Tue May 01 17:26:56 2018

physicalweb: Remove Physical Web WebUI

This change removes the UI used to see nearby Physical Web URLs.

BUG= 826540 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I11318eb2f83d73f98e5e7bed974fad30210426a8
Reviewed-on: https://chromium-review.googlesource.com/1028722
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555089}
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/chrome/browser/ui/webui/physical_web/physical_web_ui.cc
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/chrome/browser/ui/webui/physical_web/physical_web_ui.h
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/components/OWNERS
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/components/components_strings.grd
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/resources/ic_link_grey600_36dp.png
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/BUILD.gn
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/physical_web_base_message_handler.cc
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/physical_web_base_message_handler.h
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/physical_web_ui_constants.cc
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/physical_web_ui_constants.h
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/resources/physical_web.css
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/resources/physical_web.html
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web/webui/resources/physical_web.js
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/physical_web_ui_strings.grdp
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/components/resources/components_resources.grd
[delete] https://crrev.com/8e3eab9e87f949d94c605ebb5f3717d9161433a6/components/resources/physical_web_ui_resources.grdp
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/ios/chrome/browser/DEPS
[modify] https://crrev.com/a5ad5a7bd1a369ba34b9637e3aadf6ee28e16699/ios/chrome/browser/ui/webui/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f117490cc60da2525aaead3b15f4e33a3a8ce115

commit f117490cc60da2525aaead3b15f4e33a3a8ce115
Author: Conley Owens <cco3@chromium.org>
Date: Wed May 02 17:56:42 2018

physicalweb: Remove UrlManager and C++ analogs

This change removes the Physical Web UrlManager and the native hooks
associated with UrlManager.

BUG= 826540 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie0215e48c8ab1a0fac8a852c338c7f87955b603d
Reviewed-on: https://chromium-review.googlesource.com/1038062
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555462}
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/android/java_sources.gni
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/browser/BUILD.gn
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/chrome/browser/android/physical_web/eddystone_encoder_bridge.h
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/chrome/browser/android/physical_web/physical_web_data_source_android.cc
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/chrome/browser/android/physical_web/physical_web_data_source_android.h
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/chrome/browser/android/physical_web/physical_web_data_source_android_unittest.cc
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/browser/browser_process.h
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/test/BUILD.gn
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/components/BUILD.gn
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/OWNERS
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/BUILD.gn
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/fake_physical_web_data_source.cc
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/fake_physical_web_data_source.h
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/physical_web_data_source.cc
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/physical_web_data_source.h
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/physical_web_data_source_impl.cc
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/physical_web_data_source_impl.h
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/physical_web_data_source_impl_unittest.cc
[delete] https://crrev.com/20b2fa1f869ab46c47d3d0fc7b26d0dc6fb7e61b/components/physical_web/data_source/physical_web_listener.h
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/ios/chrome/browser/DEPS
[modify] https://crrev.com/f117490cc60da2525aaead3b15f4e33a3a8ce115/ios/chrome/browser/ui/webui/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6272997905461e7f485a47e985485a25001780c7

commit 6272997905461e7f485a47e985485a25001780c7
Author: Conley Owens <cco3@chromium.org>
Date: Thu May 10 18:02:55 2018

physicalweb: Remove Physical Web Service

This change removes all references to the Physical Web Service.

BUG= 826540 

Change-Id: I75a85182798073648dc0f5356b4373dddb54a662
Reviewed-on: https://chromium-review.googlesource.com/1040353
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557584}
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/BitmapHttpRequest.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClient.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
[modify] https://crrev.com/6272997905461e7f485a47e985485a25001780c7/chrome/android/java_sources.gni
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/PwsClientImplTest.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java
[delete] https://crrev.com/35bab68abc419e3242d5388c7292c3fc1a338099/chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java
[modify] https://crrev.com/6272997905461e7f485a47e985485a25001780c7/components/components_locale_settings.grd

Project Member

Comment 11 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c50e14e4fb1a885bd5013d6ba918d100307ce1e

commit 7c50e14e4fb1a885bd5013d6ba918d100307ce1e
Author: Conley Owens <cco3@chromium.org>
Date: Wed May 16 18:18:04 2018

physicalweb: Remove vestiges of the Physical Web

This change removes all code related to the Physical Web.

BUG= 826540 

Change-Id: Ifda5d80c5cebeedf2e2fdf48142e6dd6c1ef73b6
Reviewed-on: https://chromium-review.googlesource.com/1054335
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559187}
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[delete] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[delete] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
[delete] https://crrev.com/c29c8861ab54c3aef9dc7f4448d509e5f6447fd2/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/Utils.java
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/chrome/android/java_sources.gni
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/tools/metrics/actions/actions.xml
[modify] https://crrev.com/7c50e14e4fb1a885bd5013d6ba918d100307ce1e/tools/metrics/histograms/histograms.xml

Comment 12 by cco3@chromium.org, May 16 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment