Issue metadata
Sign in to add a comment
|
Support select-to-speak in multi-process mash |
||||||||||||||||||||||
Issue descriptionRight now chrome/browser calls into ash for this feature, which won't work on mustash: chromeos/chrome_browser_main_chromeos.cc:#include "ash/root_window_controller.h" chromeos/chrome_browser_main_chromeos.cc:#include "ash/shell.h"
,
Aug 15
,
Sep 6
Looks like the Automation API also doesn't work well under mash: * hit testing doesn't work * chrome.automation.getFocus doesn't return
,
Nov 5
,
Nov 8
I think select-to-speak should actually work under Mash (and for window service windows after Issue 888145 is fixed) The pre-target EventHandler is installed on the Ash side: https://cs.chromium.org/chromium/src/ash/events/select_to_speak_event_handler.cc?rcl=eeb9122621630cdc1cd3600de32ff1f17f044f75&l=27 And that class uses a mojom::SelectToSpeakEventHandlerDelegate interface to dispatch events to the extension: https://cs.chromium.org/chromium/src/ash/public/interfaces/accessibility_controller.mojom?rcl=eeb9122621630cdc1cd3600de32ff1f17f044f75&l=105 I'm going to mark this piece fixed (per katie@'s work on Issue 874295 ), thanks!
,
Nov 8
Select-to-speak won't fully work under Mash until hit-testing and chrome.automation.getFocus work. Should we leave this open until the feature actually works in Mash -- and the integration tests can run in Mash?
,
Nov 8
We can use this for multi-process mash. As katie says, there's work to do. SingleProcessMash select-to-speak is issue 889093 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Apr 19 2018