New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826525 link

Starred by 1 user
Status: WontFix
Owner:
michaeldo@chromium.org
Closed: May 2018
Cc:
█ ghendel@chromium.org
eugene...@chromium.org
linds...@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: 2018-04-09
OS: iOS
Pri: ----
Type: Task
Launch-Accessibility: NA
Launch-Legal: NA
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: Yes
Launch-UI: NA

Blocking:
issue 817517



Sign in to add a comment

iOS Context Menu iFrame Support Finch Experiment

Project Member Reported by michaeldo@chromium.org, Mar 27 2018 
Technical feature description: Supporting the Context Menu in iFrames on iOS requires sending element details back to the app using JavaScript's |postMessage|. (Instead of directly returning DOM element details from a JavaScript function.)

Eng owner: michaeldo

Design doc (send to chrome-design-docs@): https://docs.google.com/document/d/1gfVy-A5ebNfG9wG_rise34HsDpyZoWi1Cn4oV6hhTKU/edit?hl=en#

Metrics:
ContextMenu.DOMElementFetchDuration - This metric will monitor the time it takes to return element details for the Context Menu. Since the new implementation will change the way element details are fetched from the DOM for the main frame, we will monitor to ensure the performance impact is acceptable. (If performance issues are discovered, we can explore using the old implementation if the DOM element is found in the main frame.)

Comment 1 by gov...@chromium.org, Mar 28 2018 

**Bulk edit**
Feature freeze for M-67 is on March 30th, and we are trying to lock down the shipping set of features. Your feature has either M=67 or Launch-M-Target=67-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested).
 
To help clarify what's shipping, we will change the milestone label for your launch to M-68 by Monday, 04/02/18 (since there appears to be no activity in review). If you still plan to ship for M-67, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested).
 
Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!

Comment 2 by michaeldo@chromium.org, Mar 28 2018

Labels: Launch-Status-Review-Requested

Comment 3 by linds...@chromium.org, Mar 28 2018 

What percentage is this intended for launch on Stable of 67? I thought this was just Stable-Exp of 1-5%?

Comment 4 by michaeldo@chromium.org, Mar 28 2018 

I just spoke with Eugene and we can start with 1-5 rollout. If metrics look good in M67, we should ramp up to 100%. There is no need for an independent experiment in M67. (That was a potential option in M66, but the feature is now complete so it makes sense to enable it if the metrics look good during the roll out.)

Comment 5 by linds...@chromium.org, Mar 28 2018 

Thanks for the clarification!

Comment 6 by ghendel@google.com, Mar 29 2018

Blocking: 817517
Labels: -Type-Launch Type-Task
Since there's already another launch bug for context menu in iframes (817517), I'm marking this ticket about experimental rollout as a non-rollout bug that's blocking the original one.

Comment 7 by michaeldo@chromium.org, Mar 30 2018 

This experiment has been enabled on Canary and Dev with the name "IOSContextMenuFindElementAtPoint".

Comment 8 by michaeldo@chromium.org, Mar 30 2018

NextAction: 2018-04-09
Add NextAction date to review preliminary metrics and request Beta experiment approval if they look good.

Comment 9 by shbarezer@chromium.org, Apr 5 2018

Labels: -Launch-Test-NotReviewed Launch-Test-LimitedYes

Comment 10 by monor...@bugs.chromium.org, Apr 9 2018 

The NextAction date has arrived: 2018-04-09

Comment 11 by shbarezer@chromium.org, Apr 26 2018

Labels: -Launch-Test-LimitedYes Launch-Test-Yes
Updated https://bugs.chromium.org/p/chromium/issues/detail?id=817517

Comment 12 by ghendel@chromium.org, Apr 26 2018

Labels: -Launch-Status-Review-Requested Launch-Status-Approval-Requested

Comment 13 by ghendel@chromium.org, Apr 26 2018

Labels: -Launch-Status-Approval-Requested Launch-Status-Approved

Comment 14 by amineer@chromium.org, May 15 2018

Labels: -Launch-Status-Approved -Launch-M-Target-67-Dev -Launch-M-Target-67-Beta -Launch-M-Target-67-Stable-Exp -Launch-M-Target-67-Stable
Removing Launch-Status since we'll be deprecating this field and the approval is already captured in blocked bug.

Comment 15 by michaeldo@chromium.org, May 16 2018

Status: WontFix (was: Assigned)
This task is now obsolete since the launch is being tracked in crbug.com/817517. Marking as such since it is listed as blocking the launch.
►

Sign in to add a comment