New issue
Advanced search Search tips

Issue 826509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

ES3MapBufferRangeTest.CopyBufferSubData test fails on devices with GPU driver workaround 'use_client_side_arrays_for_stream_buffers' enabled

Reported by smacc...@amazon.com, Mar 27 2018

Issue description

Steps to reproduce the problem:
Prerquist:
1. Run test on a device with use_client_side_arrays_for_stream_buffers enabled

Repro Steps:
2. Run ./out/Defaul/bin/run_gl_tests -v -f "*ES3MapBufferRangeTest.CopyBufferSubData*"

What is the expected behavior?
Test to not fail

What went wrong?
Test fails with:
C   23.070s Main  ********************************************************************************
C   23.070s Main  Detailed Logs
C   23.070s Main  ********************************************************************************
C   23.070s Main  [FAIL] ES3MapBufferRangeTest.CopyBufferSubData:
C   23.070s Main  [ RUN      ] ES3MapBufferRangeTest.CopyBufferSubData
C   23.070s Main  [ERROR:gles2_cmd_decoder.cc(18928)] [GroupMarkerNotSet( crbug.com/242999 )!:F00C81AB]GL ERROR :GL_INVALID_VALUE : glMapBufferRange: <- error from previous GL command
C   23.070s Main  ../../gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:527: Failure
C   23.070s Main  Expected: (nullptr) != (map_ptr), actual: 4-byte object <00-00 00-00> vs NULL
C   23.071s Main  ../../gpu/command_buffer/tests/gl_manager.cc:449: Failure
C   23.071s Main  Value of: glGetError() == GL_NONE
C   23.071s Main    Actual: false
C   23.071s Main  Expected: true
C   23.071s Main  [  FAILED  ] ES3MapBufferRangeTest.CopyBufferSubData (16 ms)
C   23.071s Main  [----------] 1 test from ES3MapBufferRangeTest (16 ms total)
C   23.071s Main  
C   23.071s Main  [----------] Global test environment tear-down
C   23.071s Main  [==========] 1 test from 1 test case ran. (18 ms total)
C   23.071s Main  [  PASSED  ] 0 tests.
C   23.071s Main  [  FAILED  ] 1 test, listed below:
C   23.071s Main  [  FAILED  ] ES3MapBufferRangeTest.CopyBufferSubData
C   23.071s Main  ********************************************************************************
C   23.071s Main  Summary
C   23.071s Main  ********************************************************************************
C   23.071s Main  [==========] 1 test ran.
C   23.071s Main  [  PASSED  ] 0 tests.
C   23.071s Main  [  FAILED  ] 1 test, listed below:
C   23.071s Main  [  FAILED  ] ES3MapBufferRangeTest.CopyBufferSubData
C   23.071s Main  
C   23.071s Main  1 FAILED TEST
C   23.071s Main  ********************************************************************************

Did this work before? No 

Chrome version: 62.0.3202.101  Channel: stable
OS Version: 
Flash Version:
 

Comment 1 by zmo@chromium.org, Mar 28 2018

Cc: piman@chromium.org
Owner: zmo@chromium.org
Status: Assigned (was: Unconfirmed)
Let's limit this workaround for command buffer ES2/WebGL1 contexts only
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41e86f24a8c7921bf1981f21b0a944f26a859799

commit 41e86f24a8c7921bf1981f21b0a944f26a859799
Author: Zhenyao Mo <zmo@chromium.org>
Date: Thu Mar 29 23:41:00 2018

Limit use_client_side_arrays_for_stream_buffers to command buffer ES2 contexts.

Several ES3 commands do not handle that workaround at the moment.

BUG= 826509 
TEST=gl_tests
R=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2d4e53fbf8c0d548b6de414073d5afa9ac58fd26
Reviewed-on: https://chromium-review.googlesource.com/985119
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547022}
[modify] https://crrev.com/41e86f24a8c7921bf1981f21b0a944f26a859799/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/41e86f24a8c7921bf1981f21b0a944f26a859799/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/41e86f24a8c7921bf1981f21b0a944f26a859799/gpu/command_buffer/service/feature_info_unittest.cc

Comment 3 by zmo@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)

Sign in to add a comment