New issue
Advanced search Search tips

Issue 826507 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Migrate BottomSheet to MVC

Project Member Reported by mdjones@chromium.org, Mar 27 2018

Issue description

This is a tracking bug related to aligning the bottom sheet's architecture with MVC.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cec079292f55b7dd46e6ceaf1c0a0064868a2981

commit cec079292f55b7dd46e6ceaf1c0a0064868a2981
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Mar 29 20:45:40 2018

Move scrim interaction handling out of BottomSheet

The interactions with the scrim are now in the bottom sheet's
controller rather than directly in the bottom sheet. This aligns with
the MVC architecture in that the sheet's controller handles
interaction with outside classes.

Bug: 826507
Change-Id: If6c410a6704c187169c91857dee412fd7fddc6c3
Reviewed-on: https://chromium-review.googlesource.com/982638
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546941}
[modify] https://crrev.com/cec079292f55b7dd46e6ceaf1c0a0064868a2981/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/cec079292f55b7dd46e6ceaf1c0a0064868a2981/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/cec079292f55b7dd46e6ceaf1c0a0064868a2981/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetController.java

Sign in to add a comment