New issue
Advanced search Search tips

Issue 826501 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-XR



Sign in to add a comment

Update uses of VrCore shared preference files to use newer encrypted location

Project Member Reported by bsheedy@chromium.org, Mar 27 2018

Issue description

VrCore now prefers to use a path in device-encrypted storage for the shared preference settings on N+. The old location still works, as VrCore automatically moves the settings to the new location if they're detected, but we should switch to use the new location directly at some point.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c76aaefcb7ef17f2897c93fda4e2694d4b94d53a

commit c76aaefcb7ef17f2897c93fda4e2694d4b94d53a
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Mar 30 19:18:51 2018

Roll src/third_party/catapult/ d95849b99..79c4e9ed2 (1 commit)

https://chromium.googlesource.com/catapult.git/+log/d95849b99664..79c4e9ed208d

$ git log d95849b99..79c4e9ed2 --date=short --no-merges --format='%ad %ae %s'
2018-03-30 bsheedy Add support for encrypted shared prefs

Created with:
  roll-dep src/third_party/catapult
BUG= chromium:826501 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Id9a9abfacca0f10c0bef82e58385c7a712a3beda
Reviewed-on: https://chromium-review.googlesource.com/988239
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547233}
[modify] https://crrev.com/c76aaefcb7ef17f2897c93fda4e2694d4b94d53a/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86e9c080b1d48f5159fa9e229a62cbff3329314e

commit 86e9c080b1d48f5159fa9e229a62cbff3329314e
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Apr 04 00:56:16 2018

Add support for and use encrypted shared prefs

Adds support for saving shared preference files to the encrypted data
directory in the instrumentation test runner and VR Telemetry tests and
sets the VR shared preference files to use this new functionality.

Prerequisite Catapult change is at
https://chromium-review.googlesource.com/c/catapult/+/986951.

Bug:  826501 
Change-Id: Ie51003fac40536c77b5814076ae67c4a153ed31d
Reviewed-on: https://chromium-review.googlesource.com/986926
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547902}
[modify] https://crrev.com/86e9c080b1d48f5159fa9e229a62cbff3329314e/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/86e9c080b1d48f5159fa9e229a62cbff3329314e/build/android/pylib/utils/shared_preference_utils.py
[modify] https://crrev.com/86e9c080b1d48f5159fa9e229a62cbff3329314e/chrome/android/shared_preference_files/test/vr_cardboard_skipdon_setupcomplete.json
[modify] https://crrev.com/86e9c080b1d48f5159fa9e229a62cbff3329314e/chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json
[modify] https://crrev.com/86e9c080b1d48f5159fa9e229a62cbff3329314e/tools/perf/contrib/vr_benchmarks/shared_android_vr_page_state.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fb65f19d5f3dd5ee65df23166c02013eaf6c69

commit 71fb65f19d5f3dd5ee65df23166c02013eaf6c69
Author: bsheedy <bsheedy@chromium.org>
Date: Sat Apr 07 01:01:47 2018

Make DON shared prefs file use encrypted path

Sets the vr_ddview_don_setupcomplete.json shared preference file to use
the encrypted storage path. This was missed when migrating the other
VR shared pref files.

TBR=mthiesse@chromium.org

Bug:  826501 
Change-Id: Ia328d0715d28eb20913f2ab93b7c08cdc692caa0
Reviewed-on: https://chromium-review.googlesource.com/1000834
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548997}
[modify] https://crrev.com/71fb65f19d5f3dd5ee65df23166c02013eaf6c69/chrome/android/shared_preference_files/test/vr_ddview_don_setupcomplete.json

Status: Fixed (was: Assigned)
Labels: M-67 Test-Complete
Components: Internals>XR

Sign in to add a comment