chrome://device-log/ leaks unclearable information about Chrome usage history |
||||||||
Issue descriptionThe logs in chrome://device-log/ are not cleared when browsing data is removed. They leak information about when Chrome was used.
,
Mar 28 2018
,
Mar 28 2018
stevenjb@, reillyg@: You are owners of components/device_event_log/, is that the source of chrome://device-log/? As the device log contains traces of user activity, it should be cleared with history.
,
Mar 28 2018
I'm working on a patch to add a device_event_log::Clear(begin, end) function and to hook it up in the right places.
,
Mar 28 2018
It is. It would be a simple matter to add a method to clear it. Is there a tracking bug for this effort? If we clear this data we should delete the chrome log also (viewable in chrome://system under 'chrome_user_log'), and potentially data from chrome://net-internals. There is also PA_LOG (components/proximity_auth/logging/logging.h), which I believe has a debug page as well but I forget what it is. +khorimoto@
,
Mar 28 2018
PA_LOG() logs get routed to chrome://proximity-auth.
,
Mar 29 2018
Thanks for quickly fixing this! These issues came up when eladalon@ discovered that webrtc logs and many other logs keep some history indefinitely. I will create a meta bug to track this.
,
Mar 29 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae9ee335863f842e76534bb24867928a63500290 commit ae9ee335863f842e76534bb24867928a63500290 Author: Reilly Grant <reillyg@chromium.org> Date: Thu Mar 29 18:58:45 2018 Clear chrome://device-log when clearing browsing history This log contains events which are indirectly related to user activity and so should be cleared when the user requests that the browser delete this data. Bug: 826490 Change-Id: Ief8bdf0985ade4fe47084991e599aef5322003c4 Reviewed-on: https://chromium-review.googlesource.com/984718 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#546912} [modify] https://crrev.com/ae9ee335863f842e76534bb24867928a63500290/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [modify] https://crrev.com/ae9ee335863f842e76534bb24867928a63500290/components/device_event_log/device_event_log.cc [modify] https://crrev.com/ae9ee335863f842e76534bb24867928a63500290/components/device_event_log/device_event_log.h [modify] https://crrev.com/ae9ee335863f842e76534bb24867928a63500290/components/device_event_log/device_event_log_impl.cc [modify] https://crrev.com/ae9ee335863f842e76534bb24867928a63500290/components/device_event_log/device_event_log_impl.h [modify] https://crrev.com/ae9ee335863f842e76534bb24867928a63500290/components/device_event_log/device_event_log_impl_unittest.cc
,
Mar 29 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by eladalon@chromium.org
, Mar 27 2018