MediaStreamUIProxyTest.* tests are flaky |
|||||||
Issue description"MediaStreamUIProxyTest.AcceptAndStart" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVNZWRpYVN0cmVhbVVJUHJveHlUZXN0LkFjY2VwdEFuZFN0YXJ0DA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 28 2018
It appears the following tests all fail together: MediaStreamUIProxyTest.DeleteBeforeAccepted MediaStreamUIProxyTest.Deny MediaStreamUIProxyTest.AcceptAndStart MediaStreamUIProxyTest.StopFromUI MediaStreamUIProxyTest.WindowIdCallbackCalled
,
Mar 29 2018
All failures so far are on linux_chromium_rel_ng, so I will disable the tests only on Linux for now.
,
Mar 29 2018
Sample stack trace: [ RUN ] MediaStreamUIProxyTest.Deny Received signal 11 SEGV_MAPERR 00000d35cc78 #0 0x000004c60f1c base::debug::StackTrace::StackTrace() #1 0x000004c60a91 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f207701c330 <unknown> #3 0x000003d614d7 content::BrowserThreadImpl::~BrowserThreadImpl() #4 0x00000447e50a content::TestBrowserThread::~TestBrowserThread() #5 0x000001e05a51 content::MediaStreamUIProxyTest::~MediaStreamUIProxyTest() #6 0x000001e0545e content::MediaStreamUIProxyTest_Deny_Test::~MediaStreamUIProxyTest_Deny_Test() #7 0x000002d53ad1 testing::TestInfo::Run() #8 0x000002d53f67 testing::TestCase::Run() #9 0x000002d5f857 testing::internal::UnitTestImpl::RunAllTests() #10 0x000002d5f3de testing::UnitTest::Run() #11 0x0000044bbe22 base::TestSuite::Run() #12 0x0000044c49c0 base::(anonymous namespace)::LaunchUnitTestsInternal() #13 0x0000044c4810 base::LaunchUnitTests() #14 0x000002442be5 main #15 0x7f20734f8f45 __libc_start_main #16 0x0000014c702a _start r8: 0000000000000000 r9: 000027f2315a5520 r10: 000027f23169ca01 r11: 0000000000000000 r12: 000027f2314433c0 r13: 000027f23135e200 r14: 0000000007b63318 r15: 000027f23168e5a0 di: 0000000007fd9e70 si: 0000000000000000 bp: 00007ffcd1b70520 bx: 0000000007fd9e68 dx: 0000000007fd9e70 ax: 00000000014e0b70 cx: 06cd3821f9db7001 sp: 00007ffcd1b703d0 ip: 0000000003d614d7 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 000000000d35cc78 [end of stack trace]
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f234ee6f92416d983222124bbfc9f202ce6c965 commit 4f234ee6f92416d983222124bbfc9f202ce6c965 Author: Adam Rice <ricea@chromium.org> Date: Thu Mar 29 14:27:53 2018 Disable flaky MediaStreamUIProxyTest tests The following tests are flaky on the linux_chromium_rel_ng bot: MediaStreamUIProxyTest.DeleteBeforeAccepted MediaStreamUIProxyTest.Deny MediaStreamUIProxyTest.AcceptAndStart MediaStreamUIProxyTest.StopFromUI MediaStreamUIProxyTest.WindowIdCallbackCalled Disabling for OS_LINUX. TBR=sergeyu@chromium.org TBR=olka@chromium.org Bug: 826483 Change-Id: I4ed69040b441f0c129002ab83315a337b5abe798 Reviewed-on: https://chromium-review.googlesource.com/985934 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#546824} [modify] https://crrev.com/4f234ee6f92416d983222124bbfc9f202ce6c965/content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc
,
Mar 29 2018
+sergeyu It appears you wrote these tests, can you find someone to deflake and re-enable them?
,
Mar 29 2018
I suspect there's a problem with destruction ordering caused by the TestBrowserThread instances which could be fixed by using TestBrowserThreadBundle instead.
,
Mar 29 2018
Looks like the flake started after this change in BrowserThreadImpl: https://chromium.googlesource.com/chromium/src/+/8eb4dff9914d111cbce7cbc756b0c96030151762 +gab@
,
Apr 5 2018
No new flakes since tests were disabled. Removing from sheriff queue.
,
Jan 15
The tests were re-enabled in https://chromium-review.googlesource.com/c/chromium/src/+/1381432 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ricea@chromium.org
, Mar 28 2018