New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826450 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 738275



Sign in to add a comment

"IPCMojoBootstrapTest.ReceiveEmptyMessage" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 27 2018

Issue description

"IPCMojoBootstrapTest.ReceiveEmptyMessage" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihJUENNb2pvQm9vdHN0cmFwVGVzdC5SZWNlaXZlRW1wdHlNZXNzYWdlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 2 by rogerm@chromium.org, Mar 27 2018

Cc: w...@chromium.org
Components: Internals>Core
Labels: -Sheriff-Chromium OS-Linux
Status: Assigned (was: Untriaged)

Comment 3 by rogerm@chromium.org, Mar 27 2018

CL to disable test is in flight.

https://chromium-review.googlesource.com/982536
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/107d113b64b143a42430f47b95239f1a128be46c

commit 107d113b64b143a42430f47b95239f1a128be46c
Author: Roger McFarlane <rogerm@chromium.org>
Date: Tue Mar 27 21:09:38 2018

[sheriff] Disable IPCMojoBootstrapTest.ReceiveEmptyMessage

It's flaky as of https://chromium-review.googlesource.com/981445

Bug:  826450 
Change-Id: I44227231a3cc954afab40e02508bb9fd552c1507
TBR: rockot@chromium.org, wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/982536
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546259}
[modify] https://crrev.com/107d113b64b143a42430f47b95239f1a128be46c/ipc/ipc_mojo_bootstrap_unittest.cc

Comment 5 by w...@chromium.org, Mar 27 2018

Ooooh, look, moar flake: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20ARM64/builds/8253

This time both tests failed to exit, but it isn't clear whether we received the expected messages and then failed to report end-of-stream, or actually missed the expected messages.

Comment 6 by w...@chromium.org, Mar 30 2018

Connect failed again on our Fuchsia/ARM64 bot: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20ARM64/builds/8424

Comment 7 by w...@chromium.org, Apr 5 2018

Labels: OS-Fuchsia
Moar flake: https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia%20(dbg)/17989 (Fuchsia/x64 Debug FYI)

Comment 8 by w...@chromium.org, Apr 5 2018

 Issue 756112  has been merged into this issue.

Comment 9 by w...@chromium.org, Apr 5 2018

Blocking: 738275
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a47da1e4b040bb1ed33368cf893d98560133c7fc

commit a47da1e4b040bb1ed33368cf893d98560133c7fc
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Apr 05 23:21:35 2018

Fix flaky IPCMojoBootstrapTest fixture

If you don't install a connection error handler before an error can
signal, you're gonna have a bad time.

Bug:  826450 
Change-Id: I1a1b16b66449d89783aa8a9fae34e57e91a1d4f9
Reviewed-on: https://chromium-review.googlesource.com/998994
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548610}
[modify] https://crrev.com/a47da1e4b040bb1ed33368cf893d98560133c7fc/ipc/ipc_mojo_bootstrap_unittest.cc

Should really be fixed this time, for reals.
Status: Fixed (was: Assigned)

Sign in to add a comment