Luci Milo API should return 404 for non-existing buildbucket builds |
||||||
Issue description
,
Mar 27 2018
,
Mar 27 2018
Can't find it in buildbucket either: https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8951530866804323000&_h=1& That being said, this should've returned 404, not 500
,
Mar 27 2018
Interesting! I've actually tried to enter 8951529651644382896, but as soon as I hit Shift-Enter on the input field of the RPC explorer, it changes the ID to 8951529651644383000. Are we using floats for these numbers? :-/
,
Mar 27 2018
Aha! You found the maximum size for a javascript number. We work around that by putting quotes around the number :/ https://luci-milo.appspot.com/rpcexplorer/services/milo.BuildInfo/Get?request={%20%20%20%20%22buildbucket%22:%20{%20%20%20%20%20%20%20%20%22id%22:%20%228951529651644382896%22%20%20%20%20}}
,
Mar 27 2018
Hm. Would never have guess that :-).
,
Mar 27 2018
,
Mar 27 2018
WAI?
,
Apr 3 2018
This is not WAI because Milo should return 404, not 500. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by serg...@chromium.org
, Mar 27 2018