New issue
Advanced search Search tips

Issue 826403 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Luci Milo API should return 404 for non-existing buildbucket builds

Project Member Reported by serg...@chromium.org, Mar 27 2018

Issue description

Labels: -Restrict-View-Google
Blocking: 826399
Interesting! I've actually tried to enter 8951529651644382896, but as soon as I hit Shift-Enter on the input field of the RPC explorer, it changes the ID to 8951529651644383000. Are we using floats for these numbers? :-/

Comment 5 by hinoka@chromium.org, Mar 27 2018

Aha! You found the maximum size for a javascript number.

We work around that by putting quotes around the number :/

https://luci-milo.appspot.com/rpcexplorer/services/milo.BuildInfo/Get?request={%20%20%20%20%22buildbucket%22:%20{%20%20%20%20%20%20%20%20%22id%22:%20%228951529651644382896%22%20%20%20%20}}
Summary: Luci Milo API should return 404 for non-existing buildbucket builds (was: Luci Milo API fails to retrieve buildbucket builds)
Hm. Would never have guess that :-).
Blocking: -826399

Comment 8 by no...@chromium.org, Mar 27 2018

Status: WontFix (was: Untriaged)
WAI?
Status: Available (was: WontFix)
This is not WAI because Milo should return 404, not 500.

Sign in to add a comment