New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826400 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Cannot see metrics in chrome://ukm

Project Member Reported by dproy@chromium.org, Mar 27 2018

Issue description

Version: Tip of Tree

Cannot see UKM metrics in chrome://ukm. I only see the URLs and an ID. Attached screenshot. 

I did launch chrome with --enable-features=Ukm --force-enable-metrics-reporting. 
 
Screenshot from 2018-03-27 13-50-46.png
104 KB View Download

Comment 1 by dproy@chromium.org, Mar 27 2018

Cc: tdres...@chromium.org
Cc: bmcquade@chromium.org

Comment 3 by holte@chromium.org, Mar 27 2018

I'm guessing this is due to Rob's recent change to strictly enforce the UKM entry whitelist, which is delivered via finch.  If you are running a chromium build, you probably don't have a finch seed, so the whitelist is empty and no entries are recorded.

We should probably skip the whitelist check if you are running with --force-enable-metrics-reporting.
Owner: rkaplow@chromium.org
Status: Assigned (was: Untriaged)
Makes sense, I can look into it
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b44ca49e25358bfb6a562706c6cf3bbaf56a52e

commit 8b44ca49e25358bfb6a562706c6cf3bbaf56a52e
Author: Robert Kaplow <rkaplow@chromium.org>
Date: Thu Apr 05 19:07:07 2018

Make --force-enable-metrics to whitelist all entries (for local debugging)


Not supported on iOS so dev builds will not show chrome://ukm data still.

Bug:  826400 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5d2b1ddc06256903949940638ed76e5d9231da51
Reviewed-on: https://chromium-review.googlesource.com/985017
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548516}
[modify] https://crrev.com/8b44ca49e25358bfb6a562706c6cf3bbaf56a52e/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/8b44ca49e25358bfb6a562706c6cf3bbaf56a52e/components/ukm/ukm_service.cc
[modify] https://crrev.com/8b44ca49e25358bfb6a562706c6cf3bbaf56a52e/components/ukm/ukm_service.h
[modify] https://crrev.com/8b44ca49e25358bfb6a562706c6cf3bbaf56a52e/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/8b44ca49e25358bfb6a562706c6cf3bbaf56a52e/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm

Status: Fixed (was: Assigned)
THis should be fixed - let me know if you see this re-occur

Sign in to add a comment