Stop using buildnumbers for V8 recipe |
||||
Issue descriptionCurrently V8 recipe uses buildnumbers when talking to chrome-build-extract service in order to retrieve build info. This should be replaced with talking luci-milo service using its new API that allows to specify Buildbucket's ID.
,
Mar 27 2018
,
Mar 27 2018
,
Mar 27 2018
Turns out requesting buildbucket actually works, but there is limit to how large a number can be in JavaScript, hence one needs to escape buildbucket IDs using quotes when using RPC Explorer: https://luci-milo.appspot.com/rpcexplorer/services/milo.BuildInfo/Get?request={%20%20%20%20%22buildbucket%22:%20{%20%20%20%20%20%20%20%20%22id%22:%20%228951529651644382896%22%20%20%20%20}}.
,
Mar 27 2018
Looks like the result returned from new Milo endpoint does not contain list of changes associated with a build, hence we'll need to use some other service to get that information.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3d6db6547aaffedcf84cb1cf6a56be9f5ddfe4d9 commit 3d6db6547aaffedcf84cb1cf6a56be9f5ddfe4d9 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Wed Mar 28 11:33:44 2018 Add TODO about migrating to luci-milo API R=machenbach@chromium.org Bug: 826399 Change-Id: I1fda47fe5af652cdaed6542aaea58fc923c18d49 Reviewed-on: https://chromium-review.googlesource.com/980884 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> [modify] https://crrev.com/3d6db6547aaffedcf84cb1cf6a56be9f5ddfe4d9/scripts/slave/recipe_modules/v8/api.py
,
Aug 7
We've migrated to Milo API albeit not to the latest one because it does not generate list of changes like old one does. IMHO, it's not worth the effort to get rid of buildnumbers. They are well supported and used everywhere. Michael, if you still see value in getting rid of them, please re-open and explain why. |
||||
►
Sign in to add a comment |
||||
Comment 1 by serg...@chromium.org
, Mar 27 2018