New issue
Advanced search Search tips

Issue 826396 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Filesize info is not displayed if the downloaded file name is large

Project Member Reported by srikanthg@chromium.org, Mar 27 2018

Issue description

App Version: 67.0.3382.0 canary
iOS Version: 11.3, 10.3.3
Device: iPhoneX, iPad Air
URL: https://goo.gl/ZrGSvb

Steps to reproduce:
  1. Launch Google Chrome
  2. Navigate to above url and tap Download

Observed results: Observe that file size is not displayed in the download manager

Expected results: Filesize should always be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: 
Bug reproducible on Safari/Firefox: Firefox: , Safari: 
Bug reproducible on current stable build (App Version, iOS Version): M65 NA (New feature)
Bug reproducible on the current beta channel build (App Version, iOS Version): M66 NA (New Feature)

Link to video/image: https://docs.google.com/drawings/d/12YXqoMzxUNBE9nWCPNMpHDubJJ39D4tCoXtaD26UpKE/preview 
 
Labels: -Restrict-View-Google
Owner: khalilcader@chromium.org
Status: Assigned (was: Untriaged)
I assume this is WAI. Khalil, could you please confirm.
Cc: -eugene...@chromium.org
Labels: -Pri-3 M-67 Pri-1
Owner: eugene...@chromium.org
Talked with Khalil. Will add "..." to the middle of the label.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75ece3da331efd8adf536ea3560525640ec4f671

commit 75ece3da331efd8adf536ea3560525640ec4f671
Author: Eugene But <eugenebut@google.com>
Date: Thu Mar 29 18:38:40 2018

Use NSLineBreakByTruncatingMiddle lineBreakMode for download status label.

Bug:  826396 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8670db5a9c091afedd25518a8a4846fde283ba3a
Reviewed-on: https://chromium-review.googlesource.com/984829
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546876}
[modify] https://crrev.com/75ece3da331efd8adf536ea3560525640ec4f671/ios/chrome/browser/ui/download/download_manager_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on chrome canary version 67.0.3387.0 on iPhone 8 plus and iPad air with iOS 11.2.6, 11.3 following the steps mentioned in comment #0.  

Screen Shot : https://drive.google.com/file/d/1paDSqACz_okntIFDpXViniLBiSf-2w5s/view?usp=sharing

Sign in to add a comment