Open-sourced icons can go in src/ but proprietary ones must go in src-internal/. src: - TV - Speaker - Speaker group - Input - Cast for Education src-internal: - Google Home - Hangout - Meet
The following revision refers to this bug: https://chrome-internal.googlesource.com/cloudview-team/media-router/internal/+/c2ecc73c451d75c8784c3abaacef9d209c891d3e commit c2ecc73c451d75c8784c3abaacef9d209c891d3e Author: Takumi Fujimoto <takumif@google.com> Date: Fri Mar 30 22:10:12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea57a9d711ad093eb497b62606c0700f5a63f028 commit ea57a9d711ad093eb497b62606c0700f5a63f028 Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Apr 09 18:55:42 2018 Add c/b/ui/media_router/internal to .gitignore This src-internal directory contains proprietary icons for the Views Cast dialog. Bug: 826393 Change-Id: I5a23e2f9d813f8e5fa39eb0adb4a0177814b6b5c Reviewed-on: https://chromium-review.googlesource.com/1003094 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549234} [modify] https://crrev.com/ea57a9d711ad093eb497b62606c0700f5a63f028/.gitignore
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/8aa3eac3b786ed3fddae9a6e18c526d6941e2ba6 commit 8aa3eac3b786ed3fddae9a6e18c526d6941e2ba6 Author: Takumi Fujimoto <takumif@google.com> Date: Mon Apr 09 22:52:23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aadd1504792c8dc07bd46c0f4493f5630c2c1e0 commit 0aadd1504792c8dc07bd46c0f4493f5630c2c1e0 Author: src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Apr 10 03:18:08 2018 Roll src-internal/ b59810f75..8aa3eac3b (1 commit) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b59810f75793..8aa3eac3b786 $ git log b59810f75..8aa3eac3b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG= chromium:826393 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6911983835ac44c4ce52574d0485dad38cc75ac3 Reviewed-on: https://chromium-review.googlesource.com/1003757 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549407} [modify] https://crrev.com/0aadd1504792c8dc07bd46c0f4493f5630c2c1e0/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d37f3a32d266f49235d0260172a6cd85398324d5 commit d37f3a32d266f49235d0260172a6cd85398324d5 Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri Apr 13 19:42:23 2018 Implement sink list button for Harmony Cast dialog - Add CastDialogSinkButton, which will be used for sink list items in the Harmony Cast dialog. It's a subclass of HoverButton that shows a device icon and an optional status indicator (checkmark or throbber). - Add UIMediaSink, a struct containing data used to populate the button - Add Skia icons used by the button: Cast for EDU, input, speaker, speaker group, and TV Screenshot of the button (two of them) in a WIP dialog: https://drive.google.com/file/d/1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf/view?usp=sharing Dimensions and colors are subject to change in later CLs. Bug: 826089 , 826393 Change-Id: I0eef58e1c0b9bf2cff3b3d146e911d3a18c7d23c Reviewed-on: https://chromium-review.googlesource.com/996458 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#550722} [modify] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/app/vector_icons/cast_for_education.icon [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/app/vector_icons/input.icon [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/app/vector_icons/speaker.icon [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/app/vector_icons/speaker_group.icon [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/app/vector_icons/tv.icon [modify] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/browser/ui/BUILD.gn [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/browser/ui/media_router/ui_media_sink.cc [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/browser/ui/media_router/ui_media_sink.h [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h [add] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc [modify] https://crrev.com/d37f3a32d266f49235d0260172a6cd85398324d5/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b4d304c491cc4e33711f0112e9221ede4389814 commit 9b4d304c491cc4e33711f0112e9221ede4389814 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Sat Apr 14 00:29:30 2018 Revert "Implement sink list button for Harmony Cast dialog" This reverts commit d37f3a32d266f49235d0260172a6cd85398324d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 550722 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QzN2YzYTMyZDI2NmY0OTIzNWQwMjYwMTcyYTZjZDg1Mzk4MzI0ZDUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/9167 Sample Failed Step: unit_tests Original change's description: > Implement sink list button for Harmony Cast dialog > > - Add CastDialogSinkButton, which will be used for sink list items in > the Harmony Cast dialog. It's a subclass of HoverButton that shows a > device icon and an optional status indicator (checkmark or throbber). > - Add UIMediaSink, a struct containing data used to populate the button > - Add Skia icons used by the button: Cast for EDU, input, speaker, > speaker group, and TV > > Screenshot of the button (two of them) in a WIP dialog: > https://drive.google.com/file/d/1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf/view?usp=sharing > > Dimensions and colors are subject to change in later CLs. > > Bug: 826089 , 826393 > Change-Id: I0eef58e1c0b9bf2cff3b3d146e911d3a18c7d23c > Reviewed-on: https://chromium-review.googlesource.com/996458 > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Adam Parker <amp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550722} Change-Id: I78a18bd028e5574869eca8a3376a43eb5aa5dc74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826089 , 826393 Reviewed-on: https://chromium-review.googlesource.com/1012475 Cr-Commit-Position: refs/heads/master@{#550830} [modify] https://crrev.com/9b4d304c491cc4e33711f0112e9221ede4389814/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/app/vector_icons/cast_for_education.icon [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/app/vector_icons/input.icon [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/app/vector_icons/speaker.icon [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/app/vector_icons/speaker_group.icon [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/app/vector_icons/tv.icon [modify] https://crrev.com/9b4d304c491cc4e33711f0112e9221ede4389814/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/browser/ui/media_router/ui_media_sink.cc [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/browser/ui/media_router/ui_media_sink.h [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h [delete] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc [modify] https://crrev.com/9b4d304c491cc4e33711f0112e9221ede4389814/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3613946f7535f3a82c536e78ca80e95f04541b14 commit 3613946f7535f3a82c536e78ca80e95f04541b14 Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Apr 17 19:44:47 2018 Reland "Implement sink list button for Harmony Cast dialog" This is a reland of d37f3a32d266f49235d0260172a6cd85398324d5 This fixes the issue of attributes in UIMediaSink not being initialized at instantiation, which was breaking MSAN builds. TBR=estade@chromium.org,bsep@chromium.org Original change's description: > Implement sink list button for Harmony Cast dialog > > - Add CastDialogSinkButton, which will be used for sink list items in > the Harmony Cast dialog. It's a subclass of HoverButton that shows a > device icon and an optional status indicator (checkmark or throbber). > - Add UIMediaSink, a struct containing data used to populate the button > - Add Skia icons used by the button: Cast for EDU, input, speaker, > speaker group, and TV > > Screenshot of the button (two of them) in a WIP dialog: > https://drive.google.com/file/d/1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf/view?usp=sharing > > Dimensions and colors are subject to change in later CLs. > > Bug: 826089 , 826393 > Change-Id: I0eef58e1c0b9bf2cff3b3d146e911d3a18c7d23c > Reviewed-on: https://chromium-review.googlesource.com/996458 > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Adam Parker <amp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550722} Bug: 826089 , 826393 Change-Id: Ib9343fc56a96f128c3b3d2bfa5e82542e94a4441 Reviewed-on: https://chromium-review.googlesource.com/1014540 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Adam Parker <amp@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#551441} [modify] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/app/vector_icons/cast_for_education.icon [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/app/vector_icons/input.icon [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/app/vector_icons/speaker.icon [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/app/vector_icons/speaker_group.icon [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/app/vector_icons/tv.icon [modify] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/browser/ui/BUILD.gn [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/browser/ui/media_router/ui_media_sink.cc [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/browser/ui/media_router/ui_media_sink.h [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h [add] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc [modify] https://crrev.com/3613946f7535f3a82c536e78ca80e95f04541b14/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34a168e6e9a34707dfef43cf050f02af8da0bee1 commit 34a168e6e9a34707dfef43cf050f02af8da0bee1 Author: Takumi Fujimoto <takumif@chromium.org> Date: Thu May 17 00:08:50 2018 [Media Router] Make wired displays use WIRED_DISPLAY sink icon type In the WebUI dialog, this is shown with the same display icon [1]. In the Views dialog, this uses the new input icon [2]. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js?l=962 [2] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc?sq=package:chromium&l=36 Bug: 826393 Change-Id: I44333292ba95695fd64b5421303a1c8d75a74459 Reviewed-on: https://chromium-review.googlesource.com/1052912 Reviewed-by: Adam Parker <amp@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#559350} [modify] https://crrev.com/34a168e6e9a34707dfef43cf050f02af8da0bee1/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.cc [modify] https://crrev.com/34a168e6e9a34707dfef43cf050f02af8da0bee1/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Apr 2 2018