VR DOFF test segfaults |
|||||
Issue descriptionVrShellTransitionTest#testStartActivityTriggersDoffChromeActivity and VrShellTransitionTest#testStartActivityTriggersDoffAppContext have been failing recently due to segfaults. It's suspected that https://chromium-review.googlesource.com/c/chromium/src/+/978618 is the culprit. Symbolized stack trace below. signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 10124 (VrShellGL), pid 9787 (chromium.chrome) pid: 9787, tid: 10124, name: VrShellGL >>> org.chromium.chrome <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 r0 4019999a r1 00000002 r2 00000000 r3 00000000 r4 d117def8 r5 d44a29ed r6 d81770c8 r7 d7e231a8 r8 d0d79c98 r9 d01fa020 sl d0d79bc0 fp 00000000 ip d4b88241 sp d01f9c48 lr d71b00e7 pc 00000000 Stack Trace: RELADDR FUNCTION FILE:LINE 00000000 <unknown> 034aa0e3 vr::Ui::AcceptDoffPromptForTesting() ../../chrome/browser/vr/ui.cc:468:11 00e26355 base::OnceCallback<void ()>::Run() && ../../base/callback.h:95:12 00e2ea7d base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ../../base/debug/task_annotator.cc:61:33 00e42a5f base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) ../../base/message_loop/incoming_task_queue.cc:124:19 00e44517 base::MessageLoop::RunTask(base::PendingTask*) ../../base/message_loop/message_loop.cc:391:25 00e44725 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) ../../base/message_loop/message_loop.cc:403:5 00e447f3 base::MessageLoop::DoWork() ../../base/message_loop/message_loop.cc:447:16 00e44f47 base::MessagePumpForUI::DoRunLoopOnce(_JNIEnv*, base::android::JavaParamRef<_jobject*> const&, unsigned char) ../../base/message_loop/message_pump_android.cc:60:14 00e44f19 Java_org_chromium_base_SystemMessageHandler_nativeDoRunLoopOnce gen/base/base_jni_headers/base/jni/SystemMessageHandler_jni.h:46:18 00049cdd <UNKNOWN> /data/app/org.chromium.chrome-Gvsac_zNOwwcV0BdyN1ziw==/oat/arm/base.odex
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33713761abcc8f364b212ea16bc3d278e18b8987 commit 33713761abcc8f364b212ea16bc3d278e18b8987 Author: Yash Malik <ymalik@google.com> Date: Wed Mar 28 17:44:18 2018 VR: Fix VR DOFF test segfaults We were trying to cast kExitPrompt to Prompt, while kExitPrompt was the root of the prompt subtree. This CL makes kExitPrompt the actual prompt, and leaves the root nameless. Bug: 826381 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I390eb1e0d287f975910c707f4de7766d55be3cbf Reviewed-on: https://chromium-review.googlesource.com/984039 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#546538} [modify] https://crrev.com/33713761abcc8f364b212ea16bc3d278e18b8987/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/33713761abcc8f364b212ea16bc3d278e18b8987/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/33713761abcc8f364b212ea16bc3d278e18b8987/chrome/browser/vr/ui_input_manager_unittest.cc [modify] https://crrev.com/33713761abcc8f364b212ea16bc3d278e18b8987/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/33713761abcc8f364b212ea16bc3d278e18b8987/chrome/browser/vr/ui_unittest.cc
,
Mar 28 2018
,
Mar 28 2018
,
Jul 4
,
Aug 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ymalik@chromium.org
, Mar 28 2018