New issue
Advanced search Search tips

Issue 826370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 728806

Blocking:
issue 678705



Sign in to add a comment

mash: Resolve ash network_icon.h access in chrome

Project Member Reported by jamescook@chromium.org, Mar 27 2018

Issue description

Chrome uses this in a couple places to draw icons (e.g. the Wi-Fi arcs icon). Maybe there should be a utility function in //ash/public/cpp for this.

 
Blocking: 678705

Comment 2 by est...@chromium.org, Mar 27 2018

yea, should* be not that hard to pull out the parts of that which are needed in chrome/ and put them in ash/public

*given a cursory look through of dependencies

side note, I guess this is no longer true? https://cs.chromium.org/chromium/src/ash/system/network/network_icon.h?rcl=5d97f053b583d59396b6e0a154e7ba6486871d2d&l=88
Blockedon: 728806
Cc: alemate@chromium.org
Owner: steve...@chromium.org
Status: Started (was: Untriaged)
I can take this. The chrome dependencies are all scheduled to go away soonish (mprobably not 67, but hopefully 68). Basically:

* The notification UI should be migrated to ash (auto_connect_notifier.cc, tether_notification_presenter.h)
* The oobe/login UI should be deprecated now (network_menu.cc, network_dropdown.cc)



Labels: -Proj-Mustash-Mash
Labels: M-68
Labels: -Pri-3 -M-68 M-69 Pri-2
Status: Assigned (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3010ae58384a502aa18b137006e9c8bd29263110

commit 3010ae58384a502aa18b137006e9c8bd29263110
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jun 06 15:41:21 2018

Move NetworkIconImageSource and SignalStrengthImageSource to ash/public

This allows the image source to be available to Tether notifications.

This also adds kTrayImageBgAlpha to ash_constants.h for use in all
tray icon code.

Bug:  826370 
Change-Id: Ib3acedfc9c87e2e6f826cc6d2190a3be0a20eba8
Reviewed-on: https://chromium-review.googlesource.com/1082655
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564903}
[modify] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/ash/public/cpp/BUILD.gn
[add] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/ash/public/cpp/network_icon_image_source.cc
[add] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/ash/public/cpp/network_icon_image_source.h
[modify] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/ash/system/network/network_icon.cc
[modify] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/ash/system/network/network_icon.h
[modify] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/chrome/browser/ui/ash/auto_connect_notifier.cc
[modify] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/chrome/browser/ui/ash/network/tether_notification_presenter.cc
[modify] https://crrev.com/3010ae58384a502aa18b137006e9c8bd29263110/chrome/browser/ui/ash/network/tether_notification_presenter.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e

commit 7fb8a991292d9fb47cbd7dd970ef5f74cea1404e
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 12 00:15:05 2018

Move AutoConnectNotifier to src/ash for mash

AutoConnectNotifier has no src/chrome dependencies.

Bug:  826370 
Change-Id: I03fbb93d7cf971ba1fad35bf378fb8ff652568d3
Reviewed-on: https://chromium-review.googlesource.com/1082670
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566221}
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/BUILD.gn
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/ash_strings.grd
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/public/cpp/network_icon_image_source.cc
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/public/cpp/network_icon_image_source.h
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/shell.h
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/system/network/DEPS
[rename] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/system/network/auto_connect_notifier.cc
[add] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/system/network/auto_connect_notifier.h
[add] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/system/network/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/system/system_notification_controller.cc
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/ash/system/system_notification_controller.h
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chrome/browser/ui/ash/DEPS
[delete] https://crrev.com/2fb697cfa28873ffaf12d455e17637d9a6b05f58/chrome/browser/ui/ash/auto_connect_notifier.h
[delete] https://crrev.com/2fb697cfa28873ffaf12d455e17637d9a6b05f58/chrome/browser/ui/ash/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chrome/test/BUILD.gn
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chromeos/network/auto_connect_handler.cc
[modify] https://crrev.com/7fb8a991292d9fb47cbd7dd970ef5f74cea1404e/chromeos/network/auto_connect_handler.h

Status: Started (was: Assigned)
Status: Fixed (was: Started)

Sign in to add a comment