Pull NTP out of native content
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d52cbf95169733b2c623e10e90dbd28c5faf7f8 commit 5d52cbf95169733b2c623e10e90dbd28c5faf7f8 Author: Justin Cohen <justincohen@google.com> Date: Thu Apr 19 17:45:54 2018 [ios] Add back missing top safe area insets Bug: 826369 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I76ad9c0e15b1ff7599ce71d68053a2757e67fa6f Reviewed-on: https://chromium-review.googlesource.com/1016705 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#552076} [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item.h [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_header_item.mm [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/ntp_home_test_utils.h [modify] https://crrev.com/5d52cbf95169733b2c623e10e90dbd28c5faf7f8/ios/chrome/browser/ui/content_suggestions/ntp_home_test_utils.mm
Q3 -> Q4.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a502321ce43411beb048fc7fd2dc557ce8f84dc commit 9a502321ce43411beb048fc7fd2dc557ce8f84dc Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 15 14:32:37 2018 [ios] Add feature flag to present NTP directly from browser container. This CL introduces a feature flag kBrowserContainerPresentsNTP to gate this change. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If313f707a0c02d3af3b9c538a2b08ce3dda6bdd3 Reviewed-on: https://chromium-review.googlesource.com/c/1280044 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599635} [modify] https://crrev.com/9a502321ce43411beb048fc7fd2dc557ce8f84dc/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/9a502321ce43411beb048fc7fd2dc557ce8f84dc/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/9a502321ce43411beb048fc7fd2dc557ce8f84dc/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/9a502321ce43411beb048fc7fd2dc557ce8f84dc/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/9a502321ce43411beb048fc7fd2dc557ce8f84dc/ios/chrome/browser/ui/ui_feature_flags.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28bd086cb554096c34b6f332a6c2fc8fc8044035 commit 28bd086cb554096c34b6f332a6c2fc8fc8044035 Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 15 14:36:05 2018 [ios] Allow BrowserContainerViewController to add content view controllers. This work is in preparation for allowing the BVC to present the NTP. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I593ec30092fc3ab3e1a955093b0300d2af3eba6c Reviewed-on: https://chromium-review.googlesource.com/c/1280045 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599636} [modify] https://crrev.com/28bd086cb554096c34b6f332a6c2fc8fc8044035/ios/chrome/browser/ui/browser_container/browser_container_view_controller.h [modify] https://crrev.com/28bd086cb554096c34b6f332a6c2fc8fc8044035/ios/chrome/browser/ui/browser_container/browser_container_view_controller.mm [modify] https://crrev.com/28bd086cb554096c34b6f332a6c2fc8fc8044035/ios/chrome/browser/ui/browser_container/browser_container_view_controller_unittest.mm [modify] https://crrev.com/28bd086cb554096c34b6f332a6c2fc8fc8044035/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7718939972775f189ad382b11e35448b839c3de6 commit 7718939972775f189ad382b11e35448b839c3de6 Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 15 18:36:57 2018 [ios] Add NewTabPageTabHelper and NewTabPageCoordinator. In preparation to make the NTP a contained view controller of the BVC, add helper classes to track activating and deactivating the NTP from a tab helper. Currently the NTP is displayed as native content within the web content area via CRWNativeContent. Rather than go thru ios/web for a native page, instead create and use a new NTP tab helper and display the NTP directly from within ios/chrome. Historically the NTP has been a collection of fake view controllers predating view controller containment. While much of the NTP hierarchy has been updated, this will be the final change required to have a normal NTP presentation with normal UIViewControllers. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8517c0231dbfdf42185a7d82ce4ca009e9002bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1280046 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599690} [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ntp/BUILD.gn [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ntp/new_tab_page_tab_helper.h [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ntp/new_tab_page_tab_helper.mm [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ntp/new_tab_page_tab_helper_delegate.h [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm [modify] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/incognito_view_controller.h [modify] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/new_tab_page_coordinator.h [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/new_tab_page_coordinator.mm [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/new_tab_page_coordinator_unittest.mm [add] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/browser/ui/ntp/new_tab_page_owning.h [modify] https://crrev.com/7718939972775f189ad382b11e35448b839c3de6/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e26337c0c071833c06b0ff8b6e0a96bed2049fa commit 9e26337c0c071833c06b0ff8b6e0a96bed2049fa Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 15 18:56:07 2018 [ios] Present the NTP directly from the BVC. When kBrowserContainerPresentsNTP is enabled, bypass CRWNativeContent and instead present the NTP directly and return nil to ios/web. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I373f43dfe02b3242c87fe997b97238c824bda116 Reviewed-on: https://chromium-review.googlesource.com/c/1280047 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599701} [modify] https://crrev.com/9e26337c0c071833c06b0ff8b6e0a96bed2049fa/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/9e26337c0c071833c06b0ff8b6e0a96bed2049fa/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/9e26337c0c071833c06b0ff8b6e0a96bed2049fa/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/9e26337c0c071833c06b0ff8b6e0a96bed2049fa/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/9e26337c0c071833c06b0ff8b6e0a96bed2049fa/ios/chrome/browser/ui/browser_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e821c2fa2b063d515ed615719b00c279b55e47b commit 0e821c2fa2b063d515ed615719b00c279b55e47b Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 15 18:58:34 2018 [ios] Stop using wasShown and wasHidden in content suggestions. Although ContentSuggestionsViewController has been presented as a proper view controller for a while now, it has still used the CRWNativeContent methods wasShown and wasHidden to manage some state. As CRWNativeContent for the NTP will be going away, stop using this methods and instead use normal UIViewController state methods. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I64c3f3aebddd4590d71e0edea927f306c63bb542 Reviewed-on: https://chromium-review.googlesource.com/c/1280048 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599702} [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizing.h [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/0e821c2fa2b063d515ed615719b00c279b55e47b/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53475dbee93a4c14d19fcc4a6878f567d85db70b commit 53475dbee93a4c14d19fcc4a6878f567d85db70b Author: Justin Cohen <justincohen@google.com> Date: Wed Oct 17 03:58:27 2018 [ios] Deactive the NTP as soon as we navigate away. This enables us to remove the NTP as quickly as possible, without needing to add a single-use WebStateObserver callback. This only affects the kBrowserContainerContainsNTP feature. This CL also removes the use of -GetPendingItem in the NewTabPageTabHelper. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0895b6109eead0aba3cd0f95bd8c1e97e1c4be28 Reviewed-on: https://chromium-review.googlesource.com/c/1283839 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600270} [modify] https://crrev.com/53475dbee93a4c14d19fcc4a6878f567d85db70b/ios/chrome/browser/ntp/new_tab_page_tab_helper.h [modify] https://crrev.com/53475dbee93a4c14d19fcc4a6878f567d85db70b/ios/chrome/browser/ntp/new_tab_page_tab_helper.mm [modify] https://crrev.com/53475dbee93a4c14d19fcc4a6878f567d85db70b/ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm [modify] https://crrev.com/53475dbee93a4c14d19fcc4a6878f567d85db70b/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f1edaca7c4050acc6aa60f0bdf10ae1a4a2b7f8 commit 9f1edaca7c4050acc6aa60f0bdf10ae1a4a2b7f8 Author: Justin Cohen <justincohen@google.com> Date: Wed Oct 17 05:08:04 2018 [ios] Correctly set frame of NTP. This only affects the kBrowserContainerContainsNTP feature. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I93b1c0844a5071756ff4d2a23f07afb8ac2e4572 Reviewed-on: https://chromium-review.googlesource.com/c/1283840 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600281} [modify] https://crrev.com/9f1edaca7c4050acc6aa60f0bdf10ae1a4a2b7f8/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff commit dd3415c5fb90767dd2aebf66ceef5868c9ff14ff Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 22 16:06:38 2018 [ios] Save PageDisplayState directly from NTP home mediator. This is in preparation for the BVC owning the NTP coordinator instead of the NTP tab helper, where the PageDisplayState saving logic will soon be removed. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I70e64e9822246a62bd00ab0fc09b167006b4bac5 Reviewed-on: https://chromium-review.googlesource.com/c/1287320 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#601599} [modify] https://crrev.com/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.h [modify] https://crrev.com/dd3415c5fb90767dd2aebf66ceef5868c9ff14ff/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db commit 83a5a25eccf69b869ebd14fc80a24f40dc1eb1db Author: Justin Cohen <justincohen@google.com> Date: Mon Oct 22 16:10:19 2018 [ios] BVC owns NTP coordinator. Moves ownership of the NTP coordinator from the NTP tab helper to the BVC. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I470d344778f844145bbd4a615f3753b3980f1614 Reviewed-on: https://chromium-review.googlesource.com/c/1287321 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601602} [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ntp/BUILD.gn [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ntp/new_tab_page_tab_helper.h [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ntp/new_tab_page_tab_helper.mm [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ntp/new_tab_page_tab_helper_delegate.h [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/83a5a25eccf69b869ebd14fc80a24f40dc1eb1db/ios/chrome/browser/ui/ntp/new_tab_page_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3557d03ff5a52d11a231ec59c6d6d9d359004c commit 5f3557d03ff5a52d11a231ec59c6d6d9d359004c Author: Justin Cohen <justincohen@google.com> Date: Tue Oct 23 18:39:23 2018 [ios] Fix snapshotting when NTPHelper is active. When an NTP is active with the kBrowserContainerContainsNTP feature, use the correct view for taking snapshots. Rather then the webState view, use the NTP view itself. Bug: 826369 Change-Id: I86406f6ccd1423e08b0ac4f896b5ebf2600a4e85 Reviewed-on: https://chromium-review.googlesource.com/c/1291596 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602034} [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/snapshots/BUILD.gn [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/snapshots/fake_snapshot_generator_delegate.h [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/snapshots/fake_snapshot_generator_delegate.mm [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/snapshots/snapshot_generator.mm [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/snapshots/snapshot_generator_delegate.h [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/snapshots/snapshot_tab_helper_unittest.mm [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/ui/activity_services/BUILD.gn [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator_unittest.mm [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/ui/activity_services/share_to_data_builder_unittest.mm [modify] https://crrev.com/5f3557d03ff5a52d11a231ec59c6d6d9d359004c/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c751f63a32144796b89a37e9f6e2d9df78b0996e commit c751f63a32144796b89a37e9f6e2d9df78b0996e Author: Justin Cohen <justincohen@google.com> Date: Wed Oct 24 00:43:17 2018 [ios] Only update tab for NTP when BVC is active. Bug: 826369 Change-Id: I5bf700ff19089ded0c276139282fceb9f8de72e9 Reviewed-on: https://chromium-review.googlesource.com/c/1297259 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#602190} [modify] https://crrev.com/c751f63a32144796b89a37e9f6e2d9df78b0996e/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/211a27ff448dfece2058ce7cc7313ba5689a1c60 commit 211a27ff448dfece2058ce7cc7313ba5689a1c60 Author: Justin Cohen <justincohen@google.com> Date: Thu Oct 25 21:54:22 2018 [ios] Update non-native NTP for ios/web changes. Hide the error page that now shows for the NTP, Ignore |success| in -didLoadPageWithSuccess (as it's been meaningless for the NTP forever), and move NewTabPageTabHelper to activate on DidFinishNavigation as the NTP now loads asynchronously. Bug: 826369 Change-Id: I8899668daca1f7862a8d6c234d1ad6f3aa963ca0 Reviewed-on: https://chromium-review.googlesource.com/c/1298181 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602881} [modify] https://crrev.com/211a27ff448dfece2058ce7cc7313ba5689a1c60/ios/chrome/browser/ntp/new_tab_page_tab_helper.h [modify] https://crrev.com/211a27ff448dfece2058ce7cc7313ba5689a1c60/ios/chrome/browser/ntp/new_tab_page_tab_helper.mm [modify] https://crrev.com/211a27ff448dfece2058ce7cc7313ba5689a1c60/ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm [modify] https://crrev.com/211a27ff448dfece2058ce7cc7313ba5689a1c60/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm [modify] https://crrev.com/211a27ff448dfece2058ce7cc7313ba5689a1c60/ios/chrome/browser/web/chrome_web_client.mm [modify] https://crrev.com/211a27ff448dfece2058ce7cc7313ba5689a1c60/ios/chrome/browser/web/chrome_web_client_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e64858d43d7b481cc2765692628fe6639984891 commit 9e64858d43d7b481cc2765692628fe6639984891 Author: Justin Cohen <justincohen@google.com> Date: Wed Oct 31 18:28:04 2018 [ios] Correct non-crwnative NTP title. NTP title should be set earlier in DidStartNavigation. It was previously moved to didFinish to sync up with changes to ios/web. Also adds an OWNERS file. Bug: 826369 Change-Id: I1f65118aa16425b44b96e14802638e67f1acd24d Reviewed-on: https://chromium-review.googlesource.com/c/1308495 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#604340} [modify] https://crrev.com/9e64858d43d7b481cc2765692628fe6639984891/ios/chrome/browser/ntp/BUILD.gn [modify] https://crrev.com/9e64858d43d7b481cc2765692628fe6639984891/ios/chrome/browser/ntp/new_tab_page_tab_helper.h [modify] https://crrev.com/9e64858d43d7b481cc2765692628fe6639984891/ios/chrome/browser/ntp/new_tab_page_tab_helper.mm [modify] https://crrev.com/9e64858d43d7b481cc2765692628fe6639984891/ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d54a0e7b4df31d2779463082a54b1e891afdec6 commit 9d54a0e7b4df31d2779463082a54b1e891afdec6 Author: Justin Cohen <justincohen@google.com> Date: Sat Nov 03 21:15:33 2018 [ios] Wait for tab usage recorder new tabs to completely load. Previously calling -loadURL immediately after loading an NTP in a test would yield expected ios/web callbacks. With a non-native content NTP, -loadURL must be called after the NTP webState load completes. This is similar to loading any other web site. Bug: 826369 Change-Id: Ice1364aee6299ab00b5fd9f0188e56ab0c73095c Reviewed-on: https://chromium-review.googlesource.com/c/1316591 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605192} [modify] https://crrev.com/9d54a0e7b4df31d2779463082a54b1e891afdec6/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/9d54a0e7b4df31d2779463082a54b1e891afdec6/ios/chrome/test/earl_grey/chrome_earl_grey.h [modify] https://crrev.com/9d54a0e7b4df31d2779463082a54b1e891afdec6/ios/chrome/test/earl_grey/chrome_earl_grey.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c369d92b211b4103b9bdcd9475ec826d35698513 commit c369d92b211b4103b9bdcd9475ec826d35698513 Author: Justin Cohen <justincohen@google.com> Date: Wed Nov 07 06:36:25 2018 [ios] Correct navItem.title for non-nativeContent NTP. When using the non-CRWNativeContent NTP the title may be incorrectly nilled out. Instead, don't update the navigation item title if there is a loading error page. BUG: 826369 Change-Id: I6d7d45982afbc94d13d73a26b1f8c9784a3ea7dc Reviewed-on: https://chromium-review.googlesource.com/c/1316752 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#605979} [modify] https://crrev.com/c369d92b211b4103b9bdcd9475ec826d35698513/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/c369d92b211b4103b9bdcd9475ec826d35698513/ios/web/web_state/web_state_observer_inttest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/568d678e790580b1d5a4d49a190b932835aa7100 commit 568d678e790580b1d5a4d49a190b932835aa7100 Author: Justin Cohen <justincohen@google.com> Date: Mon Nov 12 20:01:40 2018 [ios] Deactive non-crw NTP on navigation to an auth error. Hide the NTP immediately when load an HTTP auth page from the NTP. |dialogPresenter| should only run when the webState->GetView() is visible. Bug: 826369 Change-Id: Ic154a4fdd4d52a2ddfec27de3ee80d85dd88cb18 Reviewed-on: https://chromium-review.googlesource.com/c/1323808 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607311} [modify] https://crrev.com/568d678e790580b1d5a4d49a190b932835aa7100/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb commit aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb Author: Justin Cohen <justincohen@google.com> Date: Tue Nov 13 03:23:32 2018 [ios] Load about://newtab internally for NTP pages. Rather than load chrome://newtab internally and eventually load an error page, internally track the NTP with about://newtab (which is a blank page). Bug: 826369 Change-Id: I2af53f90088ce4f376a4d0d0107eb667d5aa5d48 Reviewed-on: https://chromium-review.googlesource.com/c/1328185 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607467} [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/browser_about_rewriter.cc [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/chrome_url_constants.cc [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/chrome_url_constants.h [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ntp/new_tab_page_tab_helper.h [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ntp/new_tab_page_tab_helper.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/tabs/tab_model_unittest.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ui/ntp/ntp_util.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/web/chrome_web_client.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/browser/web/chrome_web_client_unittest.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/chrome/test/app/chrome_test_util.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/legacy_navigation_manager_impl.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/navigation_item_impl.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/navigation_manager_impl.h [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/navigation_manager_impl.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/session_storage_builder.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/wk_based_navigation_manager_impl.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/wk_navigation_util.h [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/wk_navigation_util.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/navigation/wk_navigation_util_unittest.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/aaea77b3e4c43ce83368b93c8abc4f23eaa4fcdb/ios/web/web_state/web_state_impl.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3d5f01053a6f8036377590cb351538b55e12788 commit c3d5f01053a6f8036377590cb351538b55e12788 Author: Justin Cohen <justincohen@google.com> Date: Tue Nov 13 04:50:47 2018 [ios] Enable BrowserContainerContainsNTP by default. Enables features to stop loading NTP from within ios/web CRWNativeContent. Instead the NTP is presented directly from the BVC. Also disables a failing pdf test that is already flakey on iOS11. Bug: 826369 Test: Any interactions to navigate to or from, hide or show, an NTP. Change-Id: I61cdcb41b2a09955f6cb994a220cd32ea8a0b602 Reviewed-on: https://chromium-review.googlesource.com/c/1332411 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607491} [modify] https://crrev.com/c3d5f01053a6f8036377590cb351538b55e12788/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm [modify] https://crrev.com/c3d5f01053a6f8036377590cb351538b55e12788/ios/chrome/browser/ui/ui_feature_flags.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58a6b4910cafd88be5a971e6cbd5e10171f91524 commit 58a6b4910cafd88be5a971e6cbd5e10171f91524 Author: Justin Cohen <justincohen@google.com> Date: Wed Nov 14 19:27:19 2018 [ios] Drop iOS10 specific code. 875528, 875528, 750185, 850814 Bug: 894099, 766951 , 836808 , 740987, 765146 , 826369 , 730461 , 869176 , Change-Id: I07b3ab43cff3d4d4f17349fe5eff9070fef5d437 Reviewed-on: https://chromium-review.googlesource.com/c/1335207 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608075} [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/app/main_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/autofill_controller_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/form_input_accessory_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/metrics/drag_and_drop_recorder.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/net/cookie_util.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/net/cookie_util_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/prerender/prerender_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/snapshots/snapshot_tab_helper.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/app_launcher/open_mail_handler_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_button.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_cell.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bubble/bubble_view_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/find_bar/find_bar_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/ntp/incognito_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/cells/page_info_item.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/print/print_controller_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/settings/settings_navigation_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tabs/tab_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/secondary_toolbar_view.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/util/uikit_ui_util.h [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/util/uikit_ui_util.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/web/cache_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/BUILD.gn [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/constraints_ui_util.h [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/constraints_ui_util.mm [delete] https://crrev.com/d8af30684b21a6141ab4b4e163eb300f6cb1c4af/ios/chrome/common/ui_util/constraints_ui_util_unittest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/showcase/payments/sc_payments_picker_egtest.mm [modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/showcase/test/showcase_eg_utils.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dc40ed9da4680e607550a48fd8636854b4476ca commit 2dc40ed9da4680e607550a48fd8636854b4476ca Author: Justin Cohen <justincohen@google.com> Date: Thu Nov 15 21:22:16 2018 [ios] Remove more iOS10 code. Followup to crrev.com/c/1335207, which missed some @available calls. Bug: 894099, 826369 , 826011 Change-Id: I901cf055264b73ac6c2cebddabb0c050e53d8f0f Reviewed-on: https://chromium-review.googlesource.com/c/1335960 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#608507} [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/BUILD.gn [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/app_launcher_coordinator.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/app_launcher_util.h [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/app_launcher/app_launcher_util.mm [delete] https://crrev.com/200318d56a2f658c725b104eec7a61d03581be57/ios/chrome/browser/ui/app_launcher/app_launcher_util_unittest.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/ntp/incognito_view.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/qr_scanner/BUILD.gn [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/qr_scanner/camera_controller.mm [delete] https://crrev.com/200318d56a2f658c725b104eec7a61d03581be57/ios/chrome/browser/ui/qr_scanner/camera_controller_unittest.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/reading_list/empty_reading_list_message_util.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/table_view/table_view_navigation_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/tabs/tab_strip_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/util/uikit_ui_util.h [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/browser/ui/util/uikit_ui_util.mm [modify] https://crrev.com/2dc40ed9da4680e607550a48fd8636854b4476ca/ios/chrome/test/BUILD.gn
Comment 1 by justincohen@chromium.org
, Apr 18 2018Owner: justincohen@chromium.org
Status: Assigned (was: Available)