New issue
Advanced search Search tips

Issue 826360 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: Apr 2018
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 825965



Sign in to add a comment

The bottom toolbar needs to work correctly in the tab switcher.

Project Member Reported by mdjones@chromium.org, Mar 27 2018 
When the bottom toolbar is enabled, the tab switcher looks broken. This is largely due to the animations being offset by the browser controls height (which is top + bottom and the browser has both now). We need to update these animations to work with or without the bottom toolbar.

Comment 1 by mdjones@chromium.org, Mar 27 2018

Labels: M-68

Comment 2 by mdjones@chromium.org, Apr 3 2018

Blocking: 825965

Comment 3 by mdjones@chromium.org, Apr 9 2018

Cc: -amaralp@chromium.org
Owner: amaralp@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a28e604f78e2a98bf1cfb61b6494da50837c9b6

commit 0a28e604f78e2a98bf1cfb61b6494da50837c9b6
Author: Pedro Amaral <amaralp@chromium.org>
Date: Thu Apr 12 22:30:28 2018

Fix tab switcher page browser control offset

Previously we only exposed the view height minus the sum of both
top and bottom browser control heights. Now we also expose the top and
bottom browser control heights. This allows the tab switcher to
correctly compute the top height offset.

BUG:  826360 
Change-Id: Ia031479621673968dc14fa1649c4f7a2d5fb2736
Reviewed-on: https://chromium-review.googlesource.com/1006365
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550389}
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerHost.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockLayoutHost.java

Comment 5 by amaralp@chromium.org, Apr 12 2018

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a28e604f78e2a98bf1cfb61b6494da50837c9b6

commit 0a28e604f78e2a98bf1cfb61b6494da50837c9b6
Author: Pedro Amaral <amaralp@chromium.org>
Date: Thu Apr 12 22:30:28 2018

Fix tab switcher page browser control offset

Previously we only exposed the view height minus the sum of both
top and bottom browser control heights. Now we also expose the top and
bottom browser control heights. This allows the tab switcher to
correctly compute the top height offset.

BUG:  826360 
Change-Id: Ia031479621673968dc14fa1649c4f7a2d5fb2736
Reviewed-on: https://chromium-review.googlesource.com/1006365
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550389}
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerHost.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java
[modify] https://crrev.com/0a28e604f78e2a98bf1cfb61b6494da50837c9b6/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockLayoutHost.java
►

Sign in to add a comment